Bugzilla – Attachment 29342 Details for
Bug 10912
Streamline hold error messages in staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 10912 - Streamline hold error messages in staff interface
SIGNED-OFF-Bug-10912---Streamline-hold-error-messa.patch (text/plain), 2.88 KB, created by
Nick Clemens (kidclamp)
on 2014-06-28 14:59:56 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 10912 - Streamline hold error messages in staff interface
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2014-06-28 14:59:56 UTC
Size:
2.88 KB
patch
obsolete
>From 70a62d79ae8e6b9bcacc1adbb4239323e71785cf Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 18 Sep 2013 16:17:42 -0400 >Subject: [PATCH] [SIGNED OFF] Bug 10912 - Streamline hold error messages in > staff interface > >Right now, if a patron cannot place a hold on any items on a record, the >error in the staff intranet looks like this: > >Cannot place hold >Too Many Holds: Kyle Hall has too many holds. >No copies are available to be placed on hold > >This can confuse some librarians, because the reason the patron cannot >place the hold is not because the patron has too many holds, but only >because there are no copies available. > >Test Plan: >1) Attempt to place a hold on a record where none of the items are > holdable. >2) Note the error messages >3) Apply this patch >4) Repeat step 1 >5) Note only the correct error message displays > >Signed-off-by: Nick Clemens <nick@quecheelibrary.org> >--- > .../intranet-tmpl/prog/en/modules/reserve/request.tt | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index cafc072..2470955 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -243,16 +243,13 @@ function checkMultiHold() { > [% UNLESS ( multi_hold ) %] > <h3>Cannot place hold</h3> > <ul> >- [% IF ( maxreserves ) %] >- <li><strong>Too many holds: </strong> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %] </a> has too many holds.</li> >- [% END %] >- [% IF ( alreadyreserved ) %] >- <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>already has a hold</strong> on this item </li> >- [% END %] > [% IF ( none_available ) %] > <li> <strong>No items are available</strong> to be placed on hold</li> >- [% END %] >- [% IF ( alreadypossession ) %] >+ [% ELSIF ( maxreserves ) %] >+ <li><strong>Too many holds: </strong> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %] </a> has too many holds.</li> >+ [% ELSIF ( alreadyreserved ) %] >+ <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>already has a hold</strong> on this item </li> >+ [% ELSIF ( alreadypossession ) %] > <li> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>is already in possession</strong> of one item</li> > [% END %] > </ul> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10912
:
21215
|
29332
|
29342
|
29435
|
29436