Bugzilla – Attachment 29380 Details for
Bug 12495
Street number missing from hold alert on checkin page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12495 - Include streetnumber in hold alert address
SIGNED-OFF-Bug-12495---Include-streetnumber-in-hol.patch (text/plain), 4.65 KB, created by
Owen Leonard
on 2014-06-30 16:36:50 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12495 - Include streetnumber in hold alert address
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-06-30 16:36:50 UTC
Size:
4.65 KB
patch
obsolete
>From fff22bc65780458eec4b8bdf706c203708ed7aaf Mon Sep 17 00:00:00 2001 >From: David Roberts <david.roberts@ptfs-europe.com> >Date: Mon, 30 Jun 2014 12:22:46 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 12495 - Include streetnumber in hold alert > address >Content-Type: text/plain; charset="utf-8" > >Steetnumber is not included in the addess in the hold alert add the >field to those displayed > >To test this, place a hold on an item that is on-loan, having first made >sure that the requesting user has a value in the street number field of >his address. Check the item in, and an alert should appear giving the >name and address of the requesting user. This address should include the >contents of the street number address field. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >I was able to confirm three of the four template changes for the >following cases: > >- Item placed on hold for a patron at the current library, not waiting >- Item placed on hold for a patron at the current library, already > waiting >- Item placed on hold for a patron at another library, not waiting > >I don't know how to trigger the case [% IF ( diffbranch ) %]. >--- > circ/returns.pl | 2 ++ > .../intranet-tmpl/prog/en/modules/circ/returns.tt | 8 ++++---- > 2 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index a95a17c..428edb1 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -384,6 +384,7 @@ if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) { > wbortitle => $borr->{'title'}, > wborphone => $borr->{'phone'}, > wboremail => $borr->{'email'}, >+ wborstnum => $borr->{streetnumber}, > wboraddress => $borr->{'address'}, > wboraddress2 => $borr->{'address2'}, > wborcity => $borr->{'city'}, >@@ -429,6 +430,7 @@ if ( $messages->{'ResFound'}) { > boremail => $borr->{'email'}, > boraddress => $borr->{'address'}, > boraddress2 => $borr->{'address2'}, >+ borstnum => $borr->{streetnumber}, > borcity => $borr->{'city'}, > borzip => $borr->{'zipcode'}, > borcnum => $borr->{'cardnumber'}, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 72f9ee3..5e67044 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -149,7 +149,7 @@ $(document).ready(function () { > [% IF ( wborcnum ) %]<h5>Hold for:</h5> > <ul><li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]"> > [% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li> >- <li>[% wboraddress %][% IF ( wboraddress2 ) %]<br /> >+ <li>[% wborstnum %] [% wboraddress %][% IF ( wboraddress2 ) %]<br /> > [% wboraddress2 %]<br />[% END %] > [% wborcity %] [% wborzip %]</li> > [% IF ( wborphone ) %]<li>[% wborphone %]</li>[% END %] >@@ -182,7 +182,7 @@ $(document).ready(function () { > <h4>Hold for:</h4> > <ul> > <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li> >- <li>[% boraddress %]<br /> >+ <li>[% borstnum %] [% boraddress %]<br /> > [% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %] > [% borcity %] [% borzip %]</li> > [% IF ( borphone ) %]<li> [% borphone %]</li>[% END %] >@@ -223,7 +223,7 @@ $(document).ready(function () { > <h4>Hold for: </h4> > <ul> > <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li> >- <li>[% boraddress %]<br /> >+ <li>[% borstnum %] [% boraddress %]<br /> > [% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %] > [% borcity %] [% borzip %]</li> > [% IF ( borphone ) %]<li>[% borphone %]</li>[% END %] >@@ -331,7 +331,7 @@ $(document).ready(function () { > <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]"> > [% borsurname %], [% borfirstname %] > </a> ([% borcnum %])</li> >- <li>[% boraddress %]<br /> >+ <li>[% borstnum %] [% boraddress %]<br /> > [% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %] > [% borcity %] [% borzip %]</li> > [% IF ( borphone ) %]<li>[% borphone %]</li>[% END %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12495
:
29378
|
29380
|
29526
|
34902
|
34903
|
34904