Bugzilla – Attachment 29410 Details for
Bug 12511
Novelist Select not using https in bootstrap
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12511 - Novelist Select not using https in bootstrap
Bug-12511---Novelist-Select-not-using-https-in-boo.patch (text/plain), 1.79 KB, created by
Kyle M Hall (khall)
on 2014-07-01 15:30:48 UTC
(
hide
)
Description:
Bug 12511 - Novelist Select not using https in bootstrap
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-07-01 15:30:48 UTC
Size:
1.79 KB
patch
obsolete
>From 24bb527a726a575169be4021224acc9d230b6e8b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 1 Jul 2014 11:29:56 -0400 >Subject: [PATCH] Bug 12511 - Novelist Select not using https in bootstrap > >In prog we have: >[% IF ( NovelistSelectProfile ) %] ><script type="text/javascript" >src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> >[% END %] > >but in bootstrap we have >[% IF ( NovelistSelectProfile ) %] ><script type="text/javascript" >src="http://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> >[% END %] > >Because bootstrap isn't using https, we get an error like this: >[blocked] The page at >'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' >was loaded over HTTPS, but ran insecure content from >'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this >content should also be loaded over HTTPS. > >Test plan would require having a subscription to Novelist Select. >I think this is trivial enough to go without. >--- > .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 5e39779..364ad3e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1108,7 +1108,7 @@ > [% END %] > > [% IF ( NovelistSelectProfile ) %] >- <script type="text/javascript" src="http://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> >+ <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> > [% END %] > > [% IF ( Babeltheque ) %] >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12511
:
29410
|
29528