Bugzilla – Attachment 29435 Details for
Bug 10912
Streamline hold error messages in staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10912 - Streamline hold error messages in staff interface
Bug-10912---Streamline-hold-error-messages-in-staf.patch (text/plain), 2.73 KB, created by
Kyle M Hall (khall)
on 2014-07-02 13:08:22 UTC
(
hide
)
Description:
Bug 10912 - Streamline hold error messages in staff interface
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-07-02 13:08:22 UTC
Size:
2.73 KB
patch
obsolete
>From 5c50cef538afef250de0f35a02a2c8c3b4f8b03b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 2 Jul 2014 09:00:46 -0400 >Subject: [PATCH] Bug 10912 - Streamline hold error messages in staff interface > >Right now, if a patron cannot place a hold on any items on a record, the >error in the staff intranet looks like this: > >Cannot place hold >Too Many Holds: Kyle Hall has too many holds. >No copies are available to be placed on hold > >This can confuse some librarians, because the reason the patron cannot >place the hold is not because the patron has too many holds, but only >because there are no copies available. > >Test Plan: >1) Apply this patch >2) Set the number of holds allowed to 1 >3) Disable AllowOnShelfHolds >4) Place a hold for a patron >5) Attempt to place a second hold for the patron >6) You should see the "Too many holds" message >7) Set the number of holds allowed to 2 >8) Repeat 5, you should be allowed to place the hold, but don't >9) Attempt to place a hold on a record with only checked in items >10) You should get a "No items are available" message >--- > .../prog/en/modules/reserve/request.tt | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index cafc072..ee4fdf5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -243,15 +243,16 @@ function checkMultiHold() { > [% UNLESS ( multi_hold ) %] > <h3>Cannot place hold</h3> > <ul> >- [% IF ( maxreserves ) %] >+ [% IF ( maxreserves ) # none_available sets maxreserves flag, so give it precedence %] > <li><strong>Too many holds: </strong> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %] </a> has too many holds.</li> >+ [% ELSIF ( none_available ) %] >+ <li> <strong>No items are available</strong> to be placed on hold</li> > [% END %] >+ > [% IF ( alreadyreserved ) %] > <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>already has a hold</strong> on this item </li> > [% END %] >- [% IF ( none_available ) %] >- <li> <strong>No items are available</strong> to be placed on hold</li> >- [% END %] >+ > [% IF ( alreadypossession ) %] > <li> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>is already in possession</strong> of one item</li> > [% END %] >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10912
:
21215
|
29332
|
29342
|
29435
|
29436