Attachment 29443 Details for Bug 12517 – [SIGNED-OFF] Bug 12517 - Download and send list popups broken in bootstrap OPAC

[patch] [SIGNED-OFF] Bug 12517 - Download and send list popups broken in bootstrap OPAC

SIGNED-OFF-Bug-12517---Download-and-send-list-popu.patch (text/plain), 2.99 KB, created by Bernardo Gonzalez Kriegel on 2014-07-02 14:19:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2014-07-02 14:19:23 UTC

Size: 2.99 KB

patch

obsolete

>From ba1547c8987534915e2761c88e0f5fcc837a0c49 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 2 Jul 2014 09:10:33 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 12517 - Download and send list popups
> broken in bootstrap OPAC
>
>A JavaScript error prevents the download list and send list links in the
>bootstrap OPAC from functioning correctly. A variable declaration was
>removed from basket.js during the creation of the theme but
>opac-shelves.tt was not changed accordingly. This patch corrects it.
>
>To test, view an existing shelf in the bootstrap OPAC and test the
>"download list" and "send list" links. They should each trigger popups
>without any errors.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Popups pops again, no koha-qa errors
>---
> .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index 87223bb..a6d9040 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -156,10 +156,10 @@
>                             <div id="toolbar" class="toolbar clearfix">
>                                 <div class="list-actions">
>                                     <a class="newshelf" href="/cgi-bin/koha/opac-shelves.pl?shelves=1">New list</a> <span class="sep">|</span>
>-                                    <a href="/cgi-bin/koha/opac-downloadshelf.pl?shelfid=[% shelfnumber %]" class="download" onclick="open(CGIBIN+'opac-downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false;">Download list</a>
>+                                    <a href="/cgi-bin/koha/opac-downloadshelf.pl?shelfid=[% shelfnumber %]" class="download" onclick="open('/cgi-bin/koha/opac-downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false;">Download list</a>
> 
>                                     [% IF Koha.Preference( 'opacuserlogin' ) == 1 %]
>-                                        <span class="sendlist"><a href="/cgi-bin/koha/opac-sendshelf.pl?shelfid=[% shelfnumber %]" class="send" onclick="open(CGIBIN+'opac-sendshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false; ">Send list</a></span>
>+                                        <span class="sendlist"><a href="/cgi-bin/koha/opac-sendshelf.pl?shelfid=[% shelfnumber %]" class="send" onclick="open('/cgi-bin/koha/opac-sendshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false; ">Send list</a></span>
>                                     [% END %]
> 
>                                     <a class="print-small" href="/cgi-bin/koha/opac-shelves.pl" onclick="print(); return false;">Print list</a>
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 12517: 29437 | 29443 | 29481