Attachment 29444 Details for Bug 11703 – Bug 11810: Input fields in OPAC suggestion form are a bit short (Bootstrap)

[patch] Bug 11810: Input fields in OPAC suggestion form are a bit short (Bootstrap)

Bug-11810-Input-fields-in-OPAC-suggestion-form-are.patch (text/plain), 4.43 KB, created by Biblibre Sandboxes on 2014-07-02 14:31:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2014-07-02 14:31:51 UTC

Size: 4.43 KB

patch

obsolete

>From eb2f79146228ac0ff3d74adc734e8b7b90152db3 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 27 Jun 2014 11:30:17 -0400
>Subject: [PATCH] Bug 11810: Input fields in OPAC suggestion form are a bit short (Bootstrap)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The default Bootstrap input size (absent any specific input size or
>class) is too short for the suggestion form. This patch adds a Bootstrap
>class to fields which need more room and adjusts the OPAC CSS to allow
>for better handling of input width at lower screen widths.
>
>To test apply the patch and clear your browser cache if necessary. Open
>the "new suggestion" form in the OPAC and confirm that the entry fields
>for title, author, publisher, and collection title are sized well.
>
>Adjust the width of your browser window up and down to confirm that the
>field sizes adjust well at various screen widths.
>
>Followed test plan. Works as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works nicely, no problems found.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>
>http://bugs.koha-community.org/show_bug.cgi?id=11703
>---
> .../bootstrap/en/modules/opac-suggestions.tt       |    8 ++++----
> koha-tmpl/opac-tmpl/bootstrap/less/responsive.less |    3 +++
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index e10f37e..b4a77d7 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -34,12 +34,12 @@
>                             <form action="/cgi-bin/koha/opac-suggestions.pl" method="post">
>                                 <fieldset class="rows">
>                                     <ol>
>-                                        <li><label class="required" for="title">Title:</label><input type="text" id="title" name="title"  maxlength="255" /></li>
>-                                        <li><label for="author">Author:</label><input type="text" id="author" name="author"  maxlength="80" /></li>
>+                                        <li><label class="required" for="title">Title:</label><input type="text" id="title" name="title" class="span6" maxlength="255" /></li>
>+                                        <li><label for="author">Author:</label><input type="text" id="author" name="author" class="span6" maxlength="80" /></li>
>                                         <li><label for="copyrightdate">Copyright date:</label><input type="text" id="copyrightdate" name="copyrightdate" size="4" maxlength="4" /></li>
>                                         <li><label for="isbn">Standard number (ISBN, ISSN or other):</label><input type="text" id="isbn" name="isbn"  maxlength="80" /></li>
>-                                        <li><label for="publishercode">Publisher:</label><input type="text" id="publishercode" name="publishercode"  maxlength="80" /></li>
>-                                        <li><label for="collectiontitle">Collection title:</label><input type="text" id="collectiontitle" name="collectiontitle"  maxlength="80" /></li>
>+                                        <li><label for="publishercode">Publisher:</label><input type="text" id="publishercode" name="publishercode" class="span6" maxlength="80" /></li>
>+                                        <li><label for="collectiontitle">Collection title:</label><input type="text" id="collectiontitle" name="collectiontitle" class="span6" maxlength="80" /></li>
>                                         <li><label for="place">Publication place:</label><input type="text" id="place" name="place"  maxlength="80" /></li>
>                                         <li><label for="itemtype">Item type:</label>
>                                             <select name="itemtype" id="itemtype">
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/less/responsive.less b/koha-tmpl/opac-tmpl/bootstrap/less/responsive.less
>index 5b4ed29..e3772b1 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/less/responsive.less
>+++ b/koha-tmpl/opac-tmpl/bootstrap/less/responsive.less
>@@ -298,6 +298,9 @@
>         margin-left : -20px;
>         margin-right : -20px;
>     }
>+    .row-fluid input.span6 {
>+        width: 48.9362%;
>+    }
> }
> 
> @media only screen and (max-width: 767px) {
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11703: 25105 | 25110 | 25111 | 25213 | 25217 | 25218 | 25220 | 25221 | 25261 | 25262 | 25263 | 25264 | 25271 | 25272 | 25289 | 25290 | 25292 | 25390 | 25391 | 25986 | 25987 | 25988 | 25989 | 25990 | 25991 | 25992 | 25993 | 25994 | 25995 | 25996 | 25997 | 25998 | 25999 | 26081 | 26085 | 26115 | 26131 | 26158 | 26160 | 26241 | 26986 | 26990 | 26991 | 27102 | 27241 | 27338 | 27339 | 27340 | 27341 | 27342 | 27349 | 27350 | 27353 | 27354 | 27356 | 27548 | 27610 | 27717 | 27718 | 27745 | 27746 | 27750 | 27751 | 28025 | 28026 | 28027 | 28028 | 28029 | 29195 | 29196 | 29197 | 29198 | 29199 | 29279 | 29280 | 29281 | 29282 | 29283 | 29284 | 29419 | 29420 | 29432 | 29433 | 29434 | 29438 | 29439 | 29440 | 29444 | 29445 | 29446 | 29447 | 29448 | 29449 | 29450 | 29451 | 29452 | 29453 | 29454 | 29472 | 29473 | 29474 | 29475 | 29476 | 29477 | 29478 | 29479 | 29480 | 29493 | 30228