Attachment 2948 Details for Bug 4984 – Revised for current HEAD

[patch] Revised for current HEAD

0001-Fix-for-Bug-4984-Invalid-XHTML-in-staff-client-searc.patch (text/plain), 13.47 KB, created by Owen Leonard on 2011-01-05 15:24:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2011-01-05 15:24:52 UTC

Size: 13.47 KB

patch

obsolete

>From 33df4b6e73123842ef904f3a9524e199418f8e2f Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 12 Jul 2010 11:41:49 -0400
>Subject: [PATCH] Fix for Bug 4984,  Invalid XHTML in staff client search results
>
>---
> .../intranet-tmpl/prog/en/includes/facets.inc      |    6 +++---
> .../prog/en/includes/page-numbers.inc              |    6 +++---
> .../prog/en/modules/catalogue/results.tmpl         |   19 ++++++++++---------
> 3 files changed, 16 insertions(+), 15 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>index c306c89..95d912d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>@@ -3,7 +3,7 @@
> <div id="search-facets">
> <h4>Refine your search</h4>
> <ul>
>-	<li>Availability<ul><li>Showing only <strong>available</strong> items. <a href="/cgi-bin/koha/catalogue/search.pl?&amp;sort_by=">Show all items</a>Limit to <a href="/cgi-bin/koha/catalogue/search.pl?&amp;sort_by=&amp;limit=available">currently available items.</a></li></ul>
>+	<li>Availability<ul><li>Showing only <strong>available</strong> items. <a href="/cgi-bin/koha/catalogue/search.pl?&amp;sort_by=">Show all items</a>Limit to <a href="/cgi-bin/koha/catalogue/search.pl?&amp;sort_by=&amp;limit=available">currently available items.</a></li></ul>
> 	 <li>(related searches: )</li>
> 	</li>
> 
>@@ -17,8 +17,8 @@
> Series
> Libraries
> <ul>
>-        <li><a href="/cgi-bin/koha/catalogue/search.pl?&amp;sort_by=&amp;limit=:" title=""></a> ) --></li>
>-        <li class="showmore"><a href="/cgi-bin/koha/catalogue/search.pl?&amp;sort_by=&amp;offset=&amp;expand=#">Show More</a></li>
>+        <li><a href="/cgi-bin/koha/catalogue/search.pl?&amp;sort_by=&amp;limit=:" title=""></a> ) --></li>
>+        <li class="showmore"><a href="/cgi-bin/koha/catalogue/search.pl?&amp;sort_by=&amp;expand=#">Show More</a></li>
> 
> </ul></li>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc
>index e7e6d0e..a9b8575 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc
>@@ -1,7 +1,7 @@
> <div class="pages">
>     
>-        <a class="nav" href="/cgi-bin/koha/catalogue/search.pl?&amp;offset=&amp;sort_by=">&lt;&lt; Previous</a>
>-    <span class="current"></span>        <a class="nav" href="/cgi-bin/koha/catalogue/search.pl?&amp;offset=&amp;sort_by="></a>
>+        <a class="nav" href="/cgi-bin/koha/catalogue/search.pl?&amp;offset=&amp;sort_by=">&lt;&lt; Previous</a>
>+    <span class="current"></span>        <a class="nav" href="/cgi-bin/koha/catalogue/search.pl?&amp;offset=&amp;sort_by="></a>
>     
>-        <a class="nav" href="/cgi-bin/koha/catalogue/search.pl?&amp;offset=&amp;sort_by=">Next &gt;&gt;</a>
>+        <a class="nav" href="/cgi-bin/koha/catalogue/search.pl?&amp;offset=&amp;sort_by=">Next &gt;&gt;</a>
> </div>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tmpl
>index 36b1fb7..669a949 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tmpl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tmpl
>@@ -321,10 +321,10 @@ function GetZ3950Terms(){
>             </form>
>         
> 
>-            
>-            <div id="facets">
>-                <dl>
>                 
>+                
>+                <div id="facets">
>+                <dl>
>                 
>                 
>                     <dt id="facets1" onclick="var Elt=document.getElementById('facets_list');if (Elt.style.display!='block'){Elt.style.display='block';} else {Elt.style.display='none';}">
>@@ -356,10 +356,11 @@ function GetZ3950Terms(){
>                     </dd>
>                 
>                 
>-                 
>                 </dl>
>             </div>
>             
>+             
>+            
> 
>             <div id="searchresults">
>                 <form action="/cgi-bin/koha/catalogue/search.pl" method="get" name="bookbag_form" id="bookbag_form">
>@@ -386,7 +387,7 @@ function GetZ3950Terms(){
>                                 <td>
>                                     <a class="p1" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=">
> 									
>-                                        <img src="http://images.amazon.com/images/P/.01.TZZZZZZZ.jpghttp://g-images.amazon.com/images/G/01/x-site/icons/no-img-sm.gif" alt="image" class="thumbnail" /> 
>+                                        <img src="http://images.amazon.com/images/P/.01.TZZZZZZZ.jpghttp://g-images.amazon.com/images/G/01/x-site/icons/no-img-sm.gif" alt="" class="thumbnail" /> 
>                                     </a></td>
>                             
>                             <td>
>@@ -441,7 +442,7 @@ function GetZ3950Terms(){
>                                     
>                                 <p>
>                                   
>-                                  <img src="" />
>+                                  <img src="" alt="" />
>                                   
>                                 </p>
>                                 
>@@ -469,7 +470,7 @@ function GetZ3950Terms(){
>                                     <ul>
>                                     
> 
>-                                        <li><li style="list-style: none; list-style-type: none;"><img src="" title="" /><li><li>
>+                                        <li><li style="list-style: none; list-style-type: none;"><img src="" title="" alt="" /><li><li>
>                                         
>                                         
>                                         [<a href="/cgi-bin/koha/catalogue/search.pl?q=callnum:"></a>]
>@@ -483,7 +484,7 @@ function GetZ3950Terms(){
>                                     
>                                        <li>
>                                         
>-                                        <li style="list-style: none; list-style-type: none;"><img src="" title="" />
>+                                        <li style="list-style: none; list-style-type: none;"><img src="" title="" alt="" />
>                                         <li>
>                                         <li>
> 
>@@ -500,7 +501,7 @@ function GetZ3950Terms(){
>                                     
>                                         <li>
>                                         
>-                                        <li style="list-style: none; list-style-type: none;"><img src="" title="" />
>+                                        <li style="list-style: none; list-style-type: none;"><img src="" title="" alt="" />
>                                         <li>
>                                         <li>
> 
>-- 
>1.7.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 4984: 2348 | 2446 | 2948