Bugzilla – Attachment 29527 Details for
Bug 12307
Catalog details page displaying incorrect status for items with itemtype level notforloan status
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status
PASSED-QA-Bug-12307---Catalog-details-page-display.patch (text/plain), 2.65 KB, created by
Katrin Fischer
on 2014-07-06 18:37:27 UTC
(
hide
)
Description:
[PASSED QA] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-07-06 18:37:27 UTC
Size:
2.65 KB
patch
obsolete
>From be8d9f12b9ef050ec32fe94e0f9730158632ea76 Mon Sep 17 00:00:00 2001 >From: Brendan Gallagher <info@bywatersolutions.com> >Date: Thu, 22 May 2014 06:37:16 -0400 >Subject: [PATCH] [PASSED QA] Bug 12307 - Catalog details page displaying > incorrect status for items with itemtype level notforloan status > >The template markup that controls that status column for >the items table in catalogue/detail.pl does not account >for the itemtypes.notforloan flag. > >Test Plan: >1) Find an item that is currently available >2) Go to the itemtype editor and mark that itemtype of that item > as being not for loan >3) Browse to the catalog details page for that item's record >4) Note the item status is still "Available" >5) Apply this patch >6) Reload the catalog details page >7) Note the item status is now "Not for loan" > >Signed-off-by: Nick Clemens <nick@quecheelibrary.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Good catch! Works as described, no problems found. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index fe8d32e..9e17a40 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -609,7 +609,7 @@ function verify_images() { > [% END %] > [% END %] > >- [% IF ( item.itemnotforloan ) %] >+ [% IF ( item.itemnotforloan || item.notforloan_per_itemtype ) %] > Not for loan > [% IF ( item.notforloanvalue ) %] > ([% item.notforloanvalue %]) >@@ -643,7 +643,16 @@ function verify_images() { > [% END %] > [% END %] > [% END %] >- [% UNLESS ( item.itemnotforloan or item.onloan or item.itemlost or item.withdrawn or item.damaged or item.transfertwhen or item.reservedate ) %] >+ [% UNLESS ( >+ item.itemnotforloan >+ or item.notforloan_per_itemtype >+ or item.onloan >+ or item.itemlost >+ or item.withdrawn >+ or item.damaged >+ or item.transfertwhen >+ or item.reservedate >+ ) %] > Available > [% END %] > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12307
:
28420
|
29491
| 29527