Attachment 29568 Details for Bug 12493 – [FOLLOW UP] Bug 12493 : moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm

[patch] [FOLLOW UP] Bug 12493 : moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm

FOLLOW-UP-Bug-12493--moving-the-subroutines-GetCon.patch (text/plain), 1.26 KB, created by Yohann Dufour on 2014-07-08 07:23:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Yohann Dufour

Created: 2014-07-08 07:23:29 UTC

Size: 1.26 KB

patch

obsolete

>From 16773811bb39c7490b5dd3288299b41350de2988 Mon Sep 17 00:00:00 2001
>From: Yohann Dufour <dufour.yohann@gmail.com>
>Date: Tue, 8 Jul 2014 09:16:48 +0200
>Subject: [PATCH] [FOLLOW UP] Bug 12493 : moving the subroutines GetContract
> and GetContracts from C4::Acquisition.pm to C4::Contract.pm
>
>Fix in order to respect the coding guidelines
>---
> C4/Acquisition.pm | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index b7f834e..fb22be9 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -18,8 +18,7 @@ package C4::Acquisition;
> # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> 
> 
>-use strict;
>-use warnings;
>+use Modern::Perl;
> use Carp;
> use C4::Context;
> use C4::Debug;
>@@ -362,9 +361,9 @@ sub GetBasketGroupAsCSV {
> 
>     my @rows;
>     for my $basket (@$baskets) {
>-        my @orders     = GetOrders( $$basket{basketno} );
>+        my @orders     = GetOrders( $basket->{basketno} );
>         my $contract   = GetContract({
>-            contractnumber => $$basket{contractnumber}
>+            contractnumber => $basket->{contractnumber}
>         });
>         my $bookseller = GetBookSellerFromId( $$basket{booksellerid} );
>         my $basketgroup = GetBasketgroup( $$basket{basketgroupid} );
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12493: 29329 | 29353 | 29494 | 29495 | 29568 | 29831 | 29832 | 29833