Bugzilla – Attachment 29800 Details for
Bug 12593
search facets die with regex error if biblio has square brackets in fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12593 - search facets die with regex error if biblio has square brackets in fields
Bug-12593---search-facets-die-with-regex-error-if-.patch (text/plain), 1.64 KB, created by
Tomás Cohen Arazi (tcohen)
on 2014-07-17 13:58:06 UTC
(
hide
)
Description:
Bug 12593 - search facets die with regex error if biblio has square brackets in fields
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2014-07-17 13:58:06 UTC
Size:
1.64 KB
patch
obsolete
>From 086eed8f6bad7d99dcd6f57fc71b28bb36d69aac Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Thu, 17 Jul 2014 12:27:55 +0200 >Subject: [PATCH] Bug 12593 - search facets die with regex error if biblio has > square brackets in fields > >It's quite common to have [something] within facet data, and it produces following error: > >Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE > >This problem was intoduced in Bug 12151 but is trivial to fix. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >Good catch. > >To test: >- Created a bibliographic record, linked to an authority record (personal name). Did a search that returned the author as a facet. >- Added a [ symbol to the author name. >- Repeated the search >=> FAIL: "Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE" >- Apply the patch >- Retry the search >=> SUCCESS: No error, bracket shows correctly. > >Passes koha-qa.pl too. >--- > C4/Search.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 1b5c6fa..219de1e 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -532,7 +532,7 @@ sub getRecords { > foreach my $field (@fields) { > my $data = $field->as_string( $subfield_letters, $facet->{sep} ); > >- unless ( grep { /^$data$/ } @used_datas ) { >+ unless ( grep { /^\Q$data\E$/ } @used_datas ) { > push @used_datas, $data; > $facets_counter->{ $facet->{idx} }->{$data}++; > } >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12593
:
29789
|
29800
|
29824