Bugzilla – Attachment 29833 Details for
Bug 12493
The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12493 : moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm
PASSED-QA-Bug-12493--moving-the-subroutines-GetCon.patch (text/plain), 1.32 KB, created by
Kyle M Hall (khall)
on 2014-07-18 13:27:07 UTC
(
hide
)
Description:
[PASSED QA] Bug 12493 : moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-07-18 13:27:07 UTC
Size:
1.32 KB
patch
obsolete
>From 9440e9b7d76c9f894a1126278c55aafd947daa42 Mon Sep 17 00:00:00 2001 >From: Yohann Dufour <dufour.yohann@gmail.com> >Date: Tue, 8 Jul 2014 09:16:48 +0200 >Subject: [PATCH] [PASSED QA] Bug 12493 : moving the subroutines GetContract and GetContracts from C4::Acquisition.pm to C4::Contract.pm > >Fix in order to respect the coding guidelines > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Acquisition.pm | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 93e4a8a..7e4fab6 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -18,8 +18,7 @@ package C4::Acquisition; > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > >-use strict; >-use warnings; >+use Modern::Perl; > use Carp; > use C4::Context; > use C4::Debug; >@@ -362,9 +361,9 @@ sub GetBasketGroupAsCSV { > > my @rows; > for my $basket (@$baskets) { >- my @orders = GetOrders( $$basket{basketno} ); >+ my @orders = GetOrders( $basket->{basketno} ); > my $contract = GetContract({ >- contractnumber => $$basket{contractnumber} >+ contractnumber => $basket->{contractnumber} > }); > my $bookseller = GetBookSellerFromId( $$basket{booksellerid} ); > my $basketgroup = GetBasketgroup( $$basket{basketgroupid} ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12493
:
29329
|
29353
|
29494
|
29495
|
29568
|
29831
|
29832
| 29833