Bugzilla – Attachment 29835 Details for
Bug 12487
C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12487 [QA Followup] - GetContract must return undef with no params
PASSED-QA-Bug-12487-QA-Followup---GetContract-must.patch (text/plain), 1.02 KB, created by
Kyle M Hall (khall)
on 2014-07-18 13:28:00 UTC
(
hide
)
Description:
[PASSED QA] Bug 12487 [QA Followup] - GetContract must return undef with no params
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-07-18 13:28:00 UTC
Size:
1.02 KB
patch
obsolete
>From 0f102c95faca7d9d1db9198a2c9fb788798c4694 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 18 Jul 2014 09:14:07 -0400 >Subject: [PATCH] [PASSED QA] Bug 12487 [QA Followup] - GetContract must return undef with no params > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Contract.pm | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > >diff --git a/C4/Contract.pm b/C4/Contract.pm >index 57978a0..4afd670 100644 >--- a/C4/Contract.pm >+++ b/C4/Contract.pm >@@ -92,7 +92,7 @@ sub GetContracts { > > =head2 GetContract > >-$contract = GetContract( { contractnumber => $contractnumber }Â ); >+$contract = GetContract( { contractnumber => $contractnumber } ); > > Looks up the contract that has PRIMKEY (contractnumber) value $contractID > >@@ -104,6 +104,8 @@ sub GetContract { > my ($params) = @_; > my $contractnumber = $params->{contractnumber}; > >+ return unless $contractnumber; >+ > my $contracts = GetContracts({ > contractnumber => $contractnumber, > }); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12487
:
29365
|
29496
|
29834
| 29835