Attachment 29911 Details for Bug 12287 – Bug 12287 - Hold priority for new hold incorrect if record has holds in transit

[patch] Bug 12287 - Hold priority for new hold incorrect if record has holds in transit

Bug-12287---Hold-priority-for-new-hold-incorrect-i.patch (text/plain), 1.31 KB, created by Jonathan Druart on 2014-07-21 08:05:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-07-21 08:05:31 UTC

Size: 1.31 KB

patch

obsolete

>From a8d8ecd1cea6d8e4a2782bb9236c098628fb9d2e Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 19 May 2014 07:01:58 -0400
>Subject: [PATCH] Bug 12287 - Hold priority for new hold incorrect if record
> has holds in transit
>
>When placing a new hold, the listed priority for the hold will be
>incorrect if there are any holds with items in transit ( i.e. found = T ).
>
>Test Plan:
>1) Place 3 holds on a record with at least 2 items
>2) Fill one hold so it is marked as waiting
>3) Fill on hold so it is marked as in transit
>4) Begin placing a new hold
>5) Note the expected priority would be 2, but is actually 3
>6) Apply this patch
>7) Reload the patch, now the expected priority shows correctly
>
>Signed-off-by: Coralie Barsacq <c.barsacq@mairie-laciotat.fr>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> reserve/request.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/reserve/request.pl b/reserve/request.pl
>index 5bd9128..eb11768 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -203,7 +203,7 @@ foreach my $biblionumber (@biblionumbers) {
>     my $alreadyreserved = 0;
> 
>     foreach my $res (@$reserves) {
>-        if ( defined $res->{found} && $res->{found} eq 'W' ) {
>+        if ( defined $res->{found} ) {
>             $count--;
>         }
> 
>-- 
>2.0.0.rc2

Actions: View | Diff | Splinter Review

Attachments on bug 12287: 28328 | 28634 | 29911 | 29912