Attachment 29953 Details for Bug 12626 – Bug 12626: SQLHelper replacement - C4::Acquisition

[patch] Bug 12626: SQLHelper replacement - C4::Acquisition

Bug-12626-SQLHelper-replacement---C4Acquisition.patch (text/plain), 1.83 KB, created by Yohann Dufour on 2014-07-22 11:51:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Yohann Dufour

Created: 2014-07-22 11:51:36 UTC

Size: 1.83 KB

patch

obsolete

>From 1cd1e39be7b6beab6cb991c7bc9019110a36ab85 Mon Sep 17 00:00:00 2001
>From: Yohann Dufour <dufour.yohann@gmail.com>
>Date: Tue, 22 Jul 2014 13:48:03 +0200
>Subject: [PATCH] Bug 12626: SQLHelper replacement - C4::Acquisition
>
>With this patch, the subroutine NewOrder uses DBIx::Class instead of C4::SQLHelper.
>
>Test plan:
>1) Apply the patch
>
>2) Execute the unit tests by launching :
>prove t/db_dependent/Acquisition.t
>
>3) The result has to be a success without error or warning :
>t/db_dependent/Acquisition.t .. ok
>All tests successful.
>Files=1, Tests=79,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.80 cusr  0.09 csys =  1.94 CPU)
>Result: PASS
>---
> C4/Acquisition.pm | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index d017d62..5a07624 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -28,7 +28,6 @@ use MARC::Record;
> use C4::Suggestions;
> use C4::Biblio;
> use C4::Debug;
>-use C4::SQLHelper qw(InsertInTable UpdateInTable);
> use C4::Bookseller qw(GetBookSellerFromId);
> use C4::Templates qw(gettemplate);
> 
>@@ -1270,17 +1269,13 @@ sub NewOrder {
>         croak "Mandatory parameter $key missing" unless $orderinfo->{$key};
>     }
> 
>-    if ( defined $orderinfo->{subscription} && $orderinfo->{'subscription'} eq 'yes' ) {
>-        $orderinfo->{'subscription'} = 1;
>-    } else {
>-        $orderinfo->{'subscription'} = 0;
>-    }
>     $orderinfo->{'entrydate'} ||= C4::Dates->new()->output("iso");
>     if (!$orderinfo->{quantityreceived}) {
>         $orderinfo->{quantityreceived} = 0;
>     }
> 
>-    my $ordernumber=InsertInTable("aqorders",$orderinfo);
>+    my $rs = Koha::Database->new()->schema->resultset('Aqorder');
>+    my $ordernumber = $rs->create($orderinfo)->id;
>     if (not $orderinfo->{parent_ordernumber}) {
>         my $sth = $dbh->prepare("
>             UPDATE aqorders
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12626: 29953 | 30093 | 30188 | 30602 | 30893