Attachment 30000 Details for Bug 11944 – Bug 11944: Remove bad FIXME in guided_report

[patch] Bug 11944: Remove bad FIXME in guided_report

Bug-11944-Remove-bad-FIXME-in-guidedreport.patch (text/plain), 1.71 KB, created by Dobrica Pavlinusic on 2014-07-23 16:22:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dobrica Pavlinusic

Created: 2014-07-23 16:22:52 UTC

Size: 1.71 KB

patch

obsolete

>From eb6fa8c5a4cfe42a8c0fd857f6817de9ab983b69 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 8 May 2014 12:59:07 +0200
>Subject: [PATCH] Bug 11944: Remove bad FIXME in guided_report
>
>Bug 11679 introduced a FIXME for this but it is wrong. The strings have
>to be encoded before generating the ods file.
>
>However, it is useless to decode column names.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
>---
> reports/guided_reports.pl |   10 +---------
> 1 files changed, 1 insertions(+), 9 deletions(-)
>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index b4d0fb1..6411ae2 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -827,7 +827,6 @@ elsif ($phase eq 'Export'){
>                 for ( my $i = 1; $i < $nb_rows +1 ; $i++ ) {
>                     $row = $doc->getRow( $table, $i );
>                     for ( my $j = 0 ; $j < $nb_cols ; $j++ ) {
>-                        # FIXME Bug 11944
>                         my $value = Encode::encode( 'UTF8', $rows->[$i - 1][$j] );
>                         $doc->cellValue( $row, $j, $value );
>                     }
>@@ -900,14 +899,7 @@ elsif ($phase eq 'Save Compound'){
> # pass $sth, get back an array of names for the column headers
> sub header_cell_values {
>     my $sth = shift or return ();
>-    my @cols;
>-    foreach my $c (@{$sth->{NAME}}) {
>-        # TODO in Bug 11944
>-        #FIXME apparently DBI still needs a utf8 fix for this?
>-        $c = Encode::decode('UTF-8', $c);
>-        push @cols, $c;
>-    }
>-    return @cols;
>+    return @{$sth->{NAME}};
> }
> 
> # pass $sth, get back a TMPL_LOOP-able set of names for the column headers
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11944: 26364 | 26365 | 26366 | 26367 | 26368 | 26369 | 26370 | 26371 | 26372 | 26407 | 26408 | 26409 | 26737 | 26738 | 26739 | 26740 | 26741 | 26742 | 26743 | 26744 | 26745 | 26746 | 26747 | 26748 | 26794 | 26857 | 26858 | 26859 | 26860 | 26861 | 26862 | 26863 | 26864 | 26865 | 26866 | 26867 | 26868 | 26869 | 26870 | 26871 | 26895 | 26921 | 27021 | 27080 | 27094 | 27158 | 27159 | 27161 | 27193 | 27194 | 27195 | 27196 | 27198 | 27199 | 27200 | 27201 | 27202 | 27203 | 27204 | 27205 | 27206 | 27207 | 27208 | 27209 | 27210 | 27211 | 27212 | 27213 | 27214 | 27215 | 27216 | 27585 | 27586 | 27587 | 27588 | 27589 | 27590 | 27591 | 27592 | 27593 | 27594 | 27595 | 27596 | 27597 | 27598 | 27599 | 27600 | 27601 | 27602 | 27603 | 27880 | 27881 | 27882 | 27883 | 27884 | 27885 | 27886 | 27887 | 27888 | 27889 | 27890 | 27891 | 27892 | 27893 | 27894 | 27895 | 27896 | 27897 | 27898 | 28046 | 28047 | 28048 | 28049 | 28050 | 28051 | 28052 | 28053 | 28054 | 28055 | 28056 | 28057 | 28058 | 28059 | 28060 | 28061 | 28062 | 28063 | 28064 | 28065 | 28066 | 28097 | 28245 | 28246 | 28247 | 28248 | 28249 | 28250 | 28251 | 28252 | 28253 | 28732 | 29981 | 29982 | 29983 | 29984 | 29985 | 29986 | 29987 | 29988 | 29989 | 29990 | 29991 | 29992 | 29993 | 29994 | 29995 | 29996 | 29997 | 29998 | 29999 | 30000 | 30001 | 30002 | 30003 | 30004 | 30005 | 30006 | 30012 | 30016 | 30945 | 31299 | 35223 | 35224 | 35225 | 35226 | 35227 | 35228 | 35229 | 35230 | 35231 | 35232 | 35233 | 35234 | 35235 | 35236 | 35237 | 35238 | 35239 | 35240 | 35241 | 35242 | 35243 | 35244 | 35245 | 35246 | 35247 | 35248 | 35249 | 35250 | 35251 | 35252 | 35253