Attachment 30044 Details for Bug 12164 – Bug 12164: (followup) keys expects a hash parameter

[patch] Bug 12164: (followup) keys expects a hash parameter

Bug-12164-followup-keys-expects-a-hash-parameter.patch (text/plain), 1.21 KB, created by Tomás Cohen Arazi (tcohen) on 2014-07-24 18:45:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2014-07-24 18:45:46 UTC

Size: 1.21 KB

patch

obsolete

>From 305224b562cb0c1e7acce4d59ba2f13994f5be8b Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Thu, 24 Jul 2014 15:40:32 -0300
>Subject: [PATCH] Bug 12164: (followup) keys expects a hash parameter
>
>As of http://perldoc.perl.org/functions/keys.html we should avoid passing
>a scalar parameter as it is not backwards compatible with squeezze's Perl
>version (5.10).
>
>Cite:
>"Starting with Perl 5.14, keys can take a scalar EXPR, which must contain a
>reference to an unblessed hash or array. The argument will be dereferenced
>automatically. This aspect of keys is considered highly experimental. The
>exact behaviour may change in a future version of Perl."
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>---
> C4/Budgets.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Budgets.pm b/C4/Budgets.pm
>index ae6a441..e0e8f72 100644
>--- a/C4/Budgets.pm
>+++ b/C4/Budgets.pm
>@@ -1109,7 +1109,7 @@ sub CloneBudgetHierarchy {
> 
>         my $tidy_budget =
>           { map { join( ' ', @columns ) =~ /$_/ ? ( $_ => $budget->{$_} ) : () }
>-              keys($budget) };
>+              keys %$budget };
>         my $new_budget_id = AddBudget(
>             {
>                 %$tidy_budget,
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12164: 27905 | 27906 | 27907 | 27908 | 27909 | 27910 | 27911 | 28588 | 28589 | 28590 | 28591 | 28592 | 28593 | 28695 | 28702 | 28703 | 28704 | 28705 | 28706 | 28707 | 28708 | 29354 | 29355 | 29356 | 29422 | 29423 | 29424 | 29425 | 29426 | 29427 | 29428 | 29429 | 29430 | 29733 | 29734 | 29735 | 29736 | 29737 | 29738 | 29739 | 29740 | 29741 | 30043 | 30044