Bugzilla – Attachment 3006 Details for
Bug 5634
Ordering branches should be case independent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
0001--SIGNED-OFF-Bug-5634-BZ5634-order-branch-list-alph.patch (text/plain), 1.14 KB, created by
Nicole C. Engard
on 2011-01-20 01:19:27 UTC
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2011-01-20 01:19:27 UTC
Size:
1.14 KB
patch
obsolete
>From 0525b32f0bdf9d284d2e48a7c325655e31eaf7a6 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Wed, 19 Jan 2011 21:48:00 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 5634: BZ5634 order branch list alphabetically, without taking care of uc/lc >Content-Type: text/plain; charset="utf-8" > >Perl separates uc & lc in cmp. So we just uc() to have list properly ordered > >Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> >--- > C4/Branch.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/Branch.pm b/C4/Branch.pm >index db7a87f..1f26e35 100644 >--- a/C4/Branch.pm >+++ b/C4/Branch.pm >@@ -160,7 +160,7 @@ sub GetBranchesLoop (;$$) { # since this is what most pages want anyway > my $onlymine = @_ ? shift : onlymine(); > my $branches = GetBranches($onlymine); > my @loop; >- foreach (sort { $branches->{$a}->{branchname} cmp $branches->{$b}->{branchname} } keys %$branches) { >+ foreach ( sort { uc($branches->{$a}->{branchname}) cmp uc($branches->{$b}->{branchname}) } keys %$branches ) { > push @loop, { > value => $_, > selected => ($_ eq $branch) ? 1 : 0, >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5634
:
3006
|
3213
|
3214
|
3215
|
3216
|
14200
|
14201
|
14220
|
14505