Bugzilla – Attachment 30246 Details for
Bug 12587
Improve output of filter information on patrons with the most checkouts report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12587 - Improve output of filter information on patrons with the most checkouts report
Bug-12587---Improve-output-of-filter-information-o.patch (text/plain), 4.70 KB, created by
Biblibre Sandboxes
on 2014-07-29 04:44:54 UTC
(
hide
)
Description:
Bug 12587 - Improve output of filter information on patrons with the most checkouts report
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2014-07-29 04:44:54 UTC
Size:
4.70 KB
patch
obsolete
>From cbf4f490bb3db9983cdbab228f8d2ace1a1c965c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 16 Jul 2014 11:23:00 -0400 >Subject: [PATCH] Bug 12587 - Improve output of filter information on patrons with the most checkouts report > >This patch makes some changes to the way filter information is displayed >after running the patrons with the most checkouts report. Before this >patch several untranslatable English strings would be displayed, and >library and item type codes would be shown instead of descriptions. > >To test, go to Reports -> Patrons checking out the most. Enter values >for all the filter options: > >- Checkout date from >- Checkout date to >- Checkin date from >- Checkin date to >- Library >- Item type >- Patron category > >When you submit the form and view the results you should see your date >submissions formatted according to your selected dateformat system >preference. The library name and item type names should be shown instead >of codes. > >Signed-off-by: Aleisha <aleishaamohia@hotmail.com> >--- > .../prog/en/modules/reports/bor_issues_top.tt | 42 +++++++++++++++++-- > reports/bor_issues_top.pl | 2 +- > 2 files changed, 38 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt >index 1526283..c3a1f23 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt >@@ -1,3 +1,6 @@ >+[% USE Branches %] >+[% USE KohaDates %] >+[% USE ItemTypes %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Reports › Patrons with the most checkouts</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -57,12 +60,41 @@ function Dopop(link) { > > > [% FOREACH mainloo IN mainloop %] >- <h1>Top [% mainloo.limit %] List patrons for checkouts</h1> >+ <h1>Patrons with the most checkouts</h1> > [% IF ( mainloo.loopfilter ) %] >- <p>Filtered on:</p> >- [% FOREACH loopfilte IN mainloo.loopfilter %] >- <p>[% IF ( loopfilte.err ) %] [% END %] [% loopfilte.crit %] =[% loopfilte.filter %][% IF ( loopfilte.err ) %] [% END %]</p> >- [% END %] >+ [% IF mainloo.loopfilter.size %] >+ <p>Filtered on:</p> >+ <ul> >+ [% FOREACH loopfilte IN mainloo.loopfilter %] >+ <li> >+ [% SWITCH loopfilte.crit -%] >+ [% CASE "Issue From" -%] >+ Checked out after [% loopfilte.filter | $KohaDates %] >+ [% CASE "Issue To" -%] >+ Checked out before [% loopfilte.filter | $KohaDates %] >+ [% CASE "Return From" -%] >+ Checked in after [% loopfilte.filter | $KohaDates %] >+ [% CASE "Return To" -%] >+ Checked in before [% loopfilte.filter | $KohaDates %] >+ [% CASE "Branch" -%] >+ Library is [% Branches.GetName( loopfilte.filter ) %] >+ [% CASE "Doc Type" -%] >+ Item type is [% ItemTypes.GetDescription( loopfilte.filter ) %] >+ [% CASE "Bor Cat" -%] >+ Patron category code is [% loopfilte.filter %] >+ [% CASE "Day" -%] >+ Day is [% loopfilte.filter %] >+ [% CASE "Month" -%] >+ Month is [% loopfilte.filter %] >+ [% CASE "Year" -%] >+ Year is [% loopfilte.filter %] >+ [% CASE # default case -%] >+ [% loopfilte.crit %] = [% loopfilte.filter %] >+ [% END -%] >+ </li> >+ [% END %] >+ </ul> >+ [% END %] > [% END %] > > <table> >diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl >index bdd58ba..f8ee8e8 100755 >--- a/reports/bor_issues_top.pl >+++ b/reports/bor_issues_top.pl >@@ -181,7 +181,7 @@ sub calculate { > $cell{err} = 1 if (@$filters[$i]<@$filters[$i-1]) ; > } > # format the dates filters, otherwise just fill as is >- $cell{filter} .= ($i>=4) ? @$filters[$i] : format_date(@$filters[$i]); >+ $cell{filter} .= @$filters[$i]; > defined ($cellmap[$i]) and > $cell{crit} .= $cellmap[$i]; > push @loopfilter, \%cell; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12587
:
29762
|
30246
|
30316
|
31490