Bugzilla – Attachment 3027 Details for
Bug 5376
Batch Edit and Delete need Superlibrarian Permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
bug5367.patch (text/plain), 2.07 KB, created by
Nicole C. Engard
on 2011-01-26 19:37:15 UTC
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2011-01-26 19:37:15 UTC
Size:
2.07 KB
patch
obsolete
>From: Ian Walls <ian.walls@bywatersolutions.com> >To: dev@bywatersolutions.com >Cc: Ian Walls <ian.walls@bywatersolutions.com> >Subject: [PATCH] Bug 5367: Batch Mod and Delete require superlibrarian permissions >Date: Tue, 25 Jan 2011 14:40:52 -0500 >Message-Id: <1295984452-23137-1-git-send-email-ian.walls@bywatersolutions.com> >X-Mailer: git-send-email 1.5.6.5 >X-Original-Sender: ian.walls@bywatersolutions.com >X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best > guess record for domain of koha@dev.bywatersolutions.com designates > 174.143.239.187 as permitted sender) smtp.mail=koha@dev.bywatersolutions.com >Precedence: list >Mailing-list: list dev@bywatersolutions.com; contact dev+owners@bywatersolutions.com >List-ID: <dev.bywatersolutions.com> >List-Help: <http://www.google.com/support/a/bywatersolutions.com/bin/static.py?hl=en_US&page=groups.cs>, > <mailto:dev+help@bywatersolutions.com> >Content-Type: text/plain; charset="utf-8" > >This only occurs with IndependantBranches turned on; in an attempt to check that the items being >modified belonged to the user's branch, the code made a simultaneous comparison and assignment, >which is not permitted in all compilations of Perl. > >Splitting the assignment of $itembranchcode and the check for its non-null value fixes the problem >--- > tools/batchMod.pl | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 921c4d6..d9a0b76 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -429,7 +429,8 @@ sub BuildItemsData{ > my %this_row; > foreach my $field (grep {$_->tag() eq $itemtagfield} $itemmarc->fields()) { > # loop through each subfield >- if (my $itembranchcode=$field->subfield($branchtagsubfield) && C4::Context->preference("IndependantBranches")) { >+ my $itembranchcode=$field->subfield($branchtagsubfield); >+ if ($itembranchcode && C4::Context->preference("IndependantBranches")) { > #verifying rights > my $userenv = C4::Context->userenv(); > unless (($userenv->{'flags'} == 1) or (($userenv->{'branch'} eq $itembranchcode))){ >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5376
: 3027