Bugzilla – Attachment 30393 Details for
Bug 12407
phone label or data switched
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12407 - phone label or data switched
Bug-12407---phone-label-or-data-switched.patch (text/plain), 4.05 KB, created by
Marcel de Rooy
on 2014-07-31 12:14:53 UTC
(
hide
)
Description:
Bug 12407 - phone label or data switched
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-07-31 12:14:53 UTC
Size:
4.05 KB
patch
obsolete
>From 8933a5dbe656654e2514cba86c728059cd093dae Mon Sep 17 00:00:00 2001 >From: Brendon Ford <brendon.ford@manhattan.edu> >Date: Thu, 12 Jun 2014 20:28:28 -0400 >Subject: [PATCH] Bug 12407 - phone label or data switched >Content-Type: text/plain; charset=utf-8 > >Fix for switched phone numbers on patron details page. > >This patch fixes switched phone numbers on patron details page and also makes phone number labels more uniform. > >To Test: > >1. Apply the patch. >2. Create/modify a patron entering some unique data into the "Secondary phone:" and "Other phone:" fields (different data for each). >3. Save the patron record. >4. Go to the patrons details page and make sure the data entered into the "Secondary phone:" field is displaying next to the "Secondary phone:" label and that the data entered into the "Other phone:" field is displaying next to the "Other phone:" label. > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../prog/en/modules/members/moremember-brief.tt | 6 +++--- > .../prog/en/modules/members/moremember.tt | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt >index c9fb845..b46424e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt >@@ -33,13 +33,13 @@ > [% IF ( emailpro ) %]<li><span class="label">Organization email: </span>[% emailpro %]</li>[% END %] > [% ELSE %] > [% IF ( phone ) %]<li><span class="label">Primary phone: </span>[% phone %]</li>[% END %] >- [% IF ( mobile ) %]<li><span class="label">Secondary phone: </span>[% mobile %]</li>[% END %] >- [% IF ( phonepro ) %]<li><span class="label">Other phone: </span>[% phonepro %]</li>[% END %] >+ [% IF ( phonepro ) %]<li><span class="label">Secondary phone: </span>[% phonepro %]</li>[% END %] >+ [% IF ( mobile ) %]<li><span class="label">Other phone: </span>[% mobile %]</li>[% END %] > [% END %] > > [% IF ( P ) %] > [% IF ( phone ) %]<li><span class="label">Primary phone: </span>[% phone %]</li>[% END %] >- [% IF ( mobile ) %]<li><span class="label">Secondary mobile: </span>[% mobile %]</li>[% END %] >+ [% IF ( mobile ) %]<li><span class="label">Other phone: </span>[% mobile %]</li>[% END %] > [% END %] > [% IF ( fax ) %]<li><span class="label">Fax: </span>[% fax %]</li>[% END %] > [% UNLESS ( I ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 74c89c9..9c8cdef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -191,13 +191,13 @@ function validate1(date) { > [% IF ( emailpro ) %]<li><span class="label">Organization email: </span>[% emailpro %]</li>[% END %] > [% ELSE %] > [% IF ( phone ) %]<li><span class="label">Primary phone: </span>[% phone %]</li>[% END %] >- [% IF ( mobile ) %]<li><span class="label">Secondary phone: </span>[% mobile %]</li>[% END %] >- [% IF ( phonepro ) %]<li><span class="label">Other phone: </span>[% phonepro %]</li>[% END %] >+ [% IF ( phonepro ) %]<li><span class="label">Secondary phone: </span>[% phonepro %]</li>[% END %] >+ [% IF ( mobile ) %]<li><span class="label">Other phone: </span>[% mobile %]</li>[% END %] > [% END %] > > [% IF ( P ) %] > [% IF ( phone ) %]<li><span class="label">Primary phone: </span>[% phone %]</li>[% END %] >- [% IF ( mobile ) %]<li><span class="label">Secondary phone: </span>[% mobile %]</li>[% END %] >+ [% IF ( mobile ) %]<li><span class="label">Other phone: </span>[% mobile %]</li>[% END %] > [% END %] > [% IF ( fax ) %]<li><span class="label">Fax: </span>[% fax %]</li>[% END %] > [% UNLESS ( I ) %] >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12407
:
28785
|
28786
|
28878
|
28879
|
28904
| 30393 |
30394
|
30549