Bugzilla – Attachment 30450 Details for
Bug 12529
Overdue notices do not respect holidays
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12529 [QA Followup] - Remove trailing whitespace
Bug-12529-QA-Followup---Remove-trailing-whitespace.patch (text/plain), 2.23 KB, created by
Kyle M Hall (khall)
on 2014-08-01 11:10:13 UTC
(
hide
)
Description:
Bug 12529 [QA Followup] - Remove trailing whitespace
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-08-01 11:10:13 UTC
Size:
2.23 KB
patch
obsolete
>From 5e5a352ddea3770810a90e3fe1be0ebe0b2e01d6 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 28 Jul 2014 13:14:25 -0400 >Subject: [PATCH] Bug 12529 [QA Followup] - Remove trailing whitespace > >--- > misc/cronjobs/overdue_notices.pl | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 4cf9f71..a0a1254 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -484,14 +484,14 @@ END_SQL > # <date> <itemcount> <firstname> <lastname> <address1> <address2> <address3> <city> <postcode> <country> > > my $borrower_sql = <<'END_SQL'; >-SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, >+SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, > TO_DAYS(?)-TO_DAYS(date_due) as difference, date_due > FROM issues,borrowers,categories > WHERE issues.borrowernumber=borrowers.borrowernumber > AND borrowers.categorycode=categories.categorycode > END_SQL > my @borrower_parameters; >- push @borrower_parameters, $date_to_run->datetime(); >+ push @borrower_parameters, $date_to_run->datetime(); > if ($branchcode) { > $borrower_sql .= ' AND issues.branchcode=? '; > push @borrower_parameters, $branchcode; >@@ -501,11 +501,11 @@ END_SQL > push @borrower_parameters, $overdue_rules->{categorycode}; > } > $borrower_sql .= ' AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber'; >- >+ > # $sth gets borrower info iff at least one overdue item has triggered the overdue action. > my $sth = $dbh->prepare($borrower_sql); > $sth->execute(@borrower_parameters); >- >+ > $verbose and warn $borrower_sql . "\n $branchcode | " . $overdue_rules->{'categorycode'} . "\n ($mindays, $maxdays, ". $date_to_run->datetime() .")\nreturns " . $sth->rows . " rows"; > my $borrowernumber; > while ( my $data = $sth->fetchrow_hashref ) { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12529
:
29507
|
29956
|
30225
|
30226
|
30227
|
30449
|
30450
|
30622