Attachment 30468 Details for Bug 12523 – [SIGNED-OFF] Bug 12523 - Add patron email in Holds awaiting pickup circulation rapport

[patch] [SIGNED-OFF] Bug 12523 - Add patron email in Holds awaiting pickup circulation rapport

SIGNED-OFF-Bug-12523---Add-patron-email-in-Holds-a.patch (text/plain), 1.48 KB, created by Owen Leonard on 2014-08-01 16:51:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2014-08-01 16:51:58 UTC

Size: 1.48 KB

patch

obsolete

>From 20c91093f3ab67a42561a8165a824c895f1892bd Mon Sep 17 00:00:00 2001
>From: simith <simith@inlibro.com>
>Date: Thu, 3 Jul 2014 08:32:32 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 12523 - Add patron email in Holds awaiting
> pickup circulation rapport
>Content-Type: text/plain; charset="utf-8"
>
>Modified:
>
>circ/waitingreservers.pl    - added GetFirstValidEmailAddress
>
>Testing:
>
>I Apply the patch
>
>0) Put an item in hold for pickup;
>1) In Circulation -> Holds awaiting pickup, validate email (column Patron);
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> circ/waitingreserves.pl |    9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/circ/waitingreserves.pl b/circ/waitingreserves.pl
>index b7b890d..07190a1 100755
>--- a/circ/waitingreserves.pl
>+++ b/circ/waitingreserves.pl
>@@ -128,10 +128,13 @@ foreach my $num (@getreserves) {
>     $getreserv{'borrowername'}      = $getborrower->{'surname'};
>     $getreserv{'borrowerfirstname'} = $getborrower->{'firstname'};
>     $getreserv{'borrowerphone'}     = $getborrower->{'phone'};
>-    if ( $getborrower->{'emailaddress'} ) {
>-        $getreserv{'borrowermail'}  = $getborrower->{'emailaddress'};
>+
>+    my $borEmail = GetFirstValidEmailAddress( $borrowernum );
>+
>+    if ( $borEmail ) {
>+        $getreserv{'borrowermail'}  = $borEmail;
>     }
>- 
>+
>     if ($today > $calcDate) {
>         if ($cancelall) {
>             my $res = cancel( $itemnumber, $borrowernum, $holdingbranch, $homebranch, !$transfer_when_cancel_all );
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 12523: 29469 | 30468 | 30492