Bugzilla – Attachment 30495 Details for
Bug 12666
Offline Circulation has poor HTML
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12666 - Fix poor HTML from circ/offline.tt
PASSED-QA-Bug-12666---Fix-poor-HTML-from-circoffli.patch (text/plain), 2.36 KB, created by
Katrin Fischer
on 2014-08-02 20:08:20 UTC
(
hide
)
Description:
[PASSED QA] Bug 12666 - Fix poor HTML from circ/offline.tt
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-08-02 20:08:20 UTC
Size:
2.36 KB
patch
obsolete
>From cfd281712ae3c65a5ca113d4b6557535e5a35b63 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 28 Jul 2014 17:36:01 -0400 >Subject: [PATCH] [PASSED QA] Bug 12666 - Fix poor HTML from circ/offline.tt > >In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt >- Cleaned up the HTML's missing </div>'s >- Corrected the autobuffer attribute to the newer preload one >- Added into empty title, since it will get replaced > >TEST PLAN >--------- >1) Run the circ/offline.pl page source through an HTML validator > -- should get a few warnings >2) Apply patch >3) Recheck page source (confirm your page isn't cached!) > -- should be clean > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Improves HTML validity, no regressions found. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt >index 0a922a5..b8a679d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt >@@ -586,8 +586,8 @@ $(document).ready(function () { > > <div id="bd"> > <div id="yui-main"> >- <audio id="alert_sound" src="[% interface %]/prog/sound/critical.ogg" autobuffer="autobuffer"></audio> >- <audio id="success_sound" src="[% interface %]/prog/sound/beep.ogg" autobuffer="autobuffer"></audio> >+ <audio id="alert_sound" src="[% interface %]/prog/sound/critical.ogg" preload="auto"></audio> >+ <audio id="success_sound" src="[% interface %]/prog/sound/beep.ogg" preload="auto"></audio> > > <div id="alerts" class="yui-b"> > </div> >@@ -761,7 +761,7 @@ $(document).ready(function () { > </div> > > <div class="yui-b offline-circulation" style="display: none;"> >- <div class="patroninfo"><h5 class="patron-title"></h5> >+ <div class="patroninfo"><h5 class="patron-title"> </h5> > <ul> > <li id="patron-address-1"></li> > <li id="patron-address-2"></li> >@@ -772,5 +772,7 @@ $(document).ready(function () { > <li id="patron-library"></li> > </ul> > </div> >+ </div> >+</div> > > [% INCLUDE 'intranet-bottom.inc' %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12666
:
30238
|
30465
| 30495