Attachment 3060 Details for Bug 5532 – Proposed fix

[patch] Proposed fix

0001-Fix-for-Bug-5532-sysprefs-editor-should-show-names-o.patch (text/plain), 2.04 KB, created by Owen Leonard on 2011-02-03 15:23:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2011-02-03 15:23:49 UTC

Size: 2.04 KB

patch

obsolete

>From e4a8fc0bf4d5b8c952e0b245c1e51118578359e4 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 11 Jan 2011 14:43:35 -0500
>Subject: [PATCH] Fix for Bug 5532 - sysprefs editor should show names of saved prefs
>Content-Type: text/plain; charset="utf-8"
>
>---
> .../intranet-tmpl/prog/en/css/preferences.css      |    5 +++++
> .../intranet-tmpl/prog/en/js/pages/preferences.js  |   11 +++++++++--
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css b/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css
>index 095b007..d9fde24 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css
>@@ -61,3 +61,8 @@ h3.collapsed {
> 	cursor : pointer;
> 	padding-left : 12px;
> }
>+
>+.humanMsg strong {
>+	display: block;
>+	font-weight: normal;
>+}
>\ No newline at end of file
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>index cbf98b8..06990b1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>@@ -9,7 +9,8 @@ $(document).ready(function() {
> 
> KOHA.Preferences = {
>     Save: function ( form ) {
>-        data = $( form ).find( '.modified' ).serialize();
>+        modified_prefs = $( form ).find( '.modified' );
>+        data = modified_prefs.serialize();
>         if ( !data ) {
>             humanMsg.displayAlert( 'Nothing to save' );
>             return;
>@@ -23,7 +24,13 @@ KOHA.Preferences = {
>         } );
>     },
>     Success: function ( form ) {
>-        humanMsg.displayAlert( 'Saved' );
>+        var msg = "";
>+        modified_prefs.each(function(){
>+            var modified_pref = $(this).attr("id");
>+            modified_pref = modified_pref.replace("pref_","");
>+            msg += '<strong>Saved preference '+modified_pref+'</strong>\n';
>+        });
>+        humanMsg.displayAlert(msg);
> 
>         $( form )
>             .find( '.modified-warning' ).remove().end()
>-- 
>1.7.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 5532: 3060