Attachment 30610 Details for Bug 12704 – Bug 12704: Remove CGI::scrolling_list from unimarc_field_225a.pl

[patch] Bug 12704: Remove CGI::scrolling_list from unimarc_field_225a.pl

Bug-12704-Remove-CGIscrollinglist-from-unimarcfiel.patch (text/plain), 3.03 KB, created by Chris Cormack on 2014-08-08 03:00:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2014-08-08 03:00:00 UTC

Size: 3.03 KB

patch

obsolete

>From c0793035be007ebe8c841bc95fda3dbadcac1217 Mon Sep 17 00:00:00 2001
>From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Date: Sat, 2 Aug 2014 21:40:35 -0300
>Subject: [PATCH] Bug 12704: Remove CGI::scrolling_list from
> unimarc_field_225a.pl
>
>This patch removes the only instance in this file
>
>To test:
>1. Apply the patch
>2. If you have UNIMARC, search for a record, edit it,
>and go to tag 225
>If you don't, edit your framework and connect this
>pluging to some tag/subtag
>3. Clic on the plugin link. If you don't have any record
>that correspond to the search, can remove the commented
>line to have something to play
>4. The collection pulldown was replaced, check that works,
>select a value and press Ok
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> cataloguing/value_builder/unimarc_field_225a.pl            | 14 ++++++--------
> .../cataloguing/value_builder/unimarc_field_225a.tt        | 12 +++++++++++-
> 2 files changed, 17 insertions(+), 9 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_225a.pl b/cataloguing/value_builder/unimarc_field_225a.pl
>index db3b4b8..0a0894b 100755
>--- a/cataloguing/value_builder/unimarc_field_225a.pl
>+++ b/cataloguing/value_builder/unimarc_field_225a.pl
>@@ -142,14 +142,12 @@ sub plugin {
>             
>     } 
>     @collections = sort @collections;
>-    #	my @collections = ["test"];
>-    my $collection = CGI::scrolling_list(
>-        -name     => 'f1',
>-        -values   => \@collections,
>-        -default  => "$result",
>-        -size     => 1,
>-        -multiple => 0,
>-    );
>+    # my @collections = ( "test" );
>+    my $collection = {
>+            values  => \@collections,
>+            default => "$result",
>+    };
>+
>     $template->param(
>         index      => $index,
>         collection => $collection
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_225a.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_225a.tt
>index 0e234b2..e888db1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_225a.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_225a.tt
>@@ -7,7 +7,17 @@
>     <div id="mainbloc">
>         <form name="f_pop" onsubmit="report()" action="">
>             <h2 class="authority">Collection</h2>
>-            <p><label>Select a collection</label>[% collection %]</p>
>+            <p><label>Select a collection</label>
>+                <select name="f1" id="f1" size="1">
>+                [% FOREACH value IN collection.values %]
>+                  [% IF ( value == collection.default ) %]
>+                    <option value="[% value %]" selected="selected">[% value %]</option>
>+                  [% ELSE %]
>+                    <option value="[% value %]">[% value %]</option>
>+                  [% END %]
>+                [% END %]
>+                </select>
>+            </p>
>             OR new collection: <input type="text" value="" name="f2"/>
>             <br/>
>             <input type="submit" value="OK" class="button authority" />
>-- 
>2.0.1

Actions: View | Diff | Splinter Review

Attachments on bug 12704: 30506 | 30610 | 30894