Bugzilla – Attachment 30670 Details for
Bug 12727
Patron category filter in batch patron deletion tool is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12727 - Patron category filter in batch patron deletion tool is broken
PASSED-QA-Bug-12727---Patron-category-filter-in-ba.patch (text/plain), 1.50 KB, created by
Katrin Fischer
on 2014-08-10 21:27:52 UTC
(
hide
)
Description:
[PASSED QA] Bug 12727 - Patron category filter in batch patron deletion tool is broken
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-08-10 21:27:52 UTC
Size:
1.50 KB
patch
obsolete
>From 05181b3390e0af1695673e6977abed142f6e0c33 Mon Sep 17 00:00:00 2001 >From: Jacek Ablewicz <abl@biblos.pk.edu.pl> >Date: Thu, 7 Aug 2014 10:29:37 +0200 >Subject: [PATCH] [PASSED QA] Bug 12727 - Patron category filter in batch > patron deletion tool is broken > >After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category >filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't >work properly any longer. It's still possible to choose a patron >category as selection criterion, but this criterion is being >efectivelly ignored on futhers steps. > >As a result, all patrons (with no check-outs and no outstanding >account balance) may get mistakenly deleted when using this tool, >despite their respective categories. > >To test: > >1/ apply patch >2/ follow the test plan[s] for Bug 11975 > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as described, no problems found. >--- > tools/cleanborrowers.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/cleanborrowers.pl b/tools/cleanborrowers.pl >index 3563c9d..9a9c1ca 100755 >--- a/tools/cleanborrowers.pl >+++ b/tools/cleanborrowers.pl >@@ -183,7 +183,7 @@ sub _get_selection_params { > dateformat => 'iso', > dateonly => 1 > }) if $borrower_dateexpiry; >- $params->{borrower_categorycode} = $borrower_categorycode if $borrower_categorycode; >+ $params->{category_code} = $borrower_categorycode if $borrower_categorycode; > > return $params; > }; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12727
:
30568
|
30608
| 30670