Attachment 30672 Details for Bug 12298 – [PASSED QA] Bug 12298: The "feed" MTT does not seem to be used and can be removed

[patch] [PASSED QA] Bug 12298: The "feed" MTT does not seem to be used and can be removed

PASSED-QA-Bug-12298-The-feed-MTT-does-not-seem-to-.patch (text/plain), 6.45 KB, created by Katrin Fischer on 2014-08-10 21:50:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-08-10 21:50:11 UTC

Size: 6.45 KB

patch

obsolete

>From eeb874e0a71691ff1b44451da5ea06a22c8a214b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 21 May 2014 10:18:38 +0200
>Subject: [PATCH] [PASSED QA] Bug 12298: The "feed" MTT does not seem to be
> used and can be removed
>
>The feed message transport type exists but nobody knows how it can be
>used. This patch assumes nobody uses it and removes it.
>
>Before removing the entry in the DB, the updatedb entry will check if no
>foreign key exists in order to avoid a delete in cascade.
>
>This path does *not* deletes the occurrences in the templates.
>
>Test plan:
>Apply this patch, execute the updatedb script and verify the
>message_transport_types table does not contain the 'feed' entry if it was not
>in use.
>
>Signed-off-by: Nick Clemens <nick@nick@quecheelibrary.org>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Patch will remove the confusing option to configure message texts for feeds.
>Checked on a database with an existing feed type notice (not deleted) and
>on one without any references to the feed message transport type (deleted!)
>---
> .../de-DE/mandatory/message_transport_types.sql    |  1 -
> .../mysql/en/mandatory/message_transport_types.sql |  1 -
> .../es-ES/mandatory/message_transport_types.sql    |  1 -
> .../1-Obligatoire/message_transport_types.sql      |  1 -
> .../it-IT/necessari/message_transport_types.sql    |  1 -
> .../1-Obligatorisk/message_transport_types.sql     |  1 -
> .../ru-RU/mandatory/message_transport_types.sql    |  1 -
> .../uk-UA/mandatory/message_transport_types.sql    |  1 -
> installer/data/mysql/updatedatabase.pl             | 30 ++++++++++++++++++++++
> 9 files changed, 30 insertions(+), 8 deletions(-)
>
>diff --git a/installer/data/mysql/de-DE/mandatory/message_transport_types.sql b/installer/data/mysql/de-DE/mandatory/message_transport_types.sql
>index d4d7de4..ed3c4ad 100644
>--- a/installer/data/mysql/de-DE/mandatory/message_transport_types.sql
>+++ b/installer/data/mysql/de-DE/mandatory/message_transport_types.sql
>@@ -4,5 +4,4 @@ values
> ('email'),
> ('print'),
> ('sms'),
>-('feed'),
> ('phone');
>diff --git a/installer/data/mysql/en/mandatory/message_transport_types.sql b/installer/data/mysql/en/mandatory/message_transport_types.sql
>index d4d7de4..ed3c4ad 100644
>--- a/installer/data/mysql/en/mandatory/message_transport_types.sql
>+++ b/installer/data/mysql/en/mandatory/message_transport_types.sql
>@@ -4,5 +4,4 @@ values
> ('email'),
> ('print'),
> ('sms'),
>-('feed'),
> ('phone');
>diff --git a/installer/data/mysql/es-ES/mandatory/message_transport_types.sql b/installer/data/mysql/es-ES/mandatory/message_transport_types.sql
>index d4d7de4..ed3c4ad 100644
>--- a/installer/data/mysql/es-ES/mandatory/message_transport_types.sql
>+++ b/installer/data/mysql/es-ES/mandatory/message_transport_types.sql
>@@ -4,5 +4,4 @@ values
> ('email'),
> ('print'),
> ('sms'),
>-('feed'),
> ('phone');
>diff --git a/installer/data/mysql/fr-FR/1-Obligatoire/message_transport_types.sql b/installer/data/mysql/fr-FR/1-Obligatoire/message_transport_types.sql
>index 3a90e76..5355973 100644
>--- a/installer/data/mysql/fr-FR/1-Obligatoire/message_transport_types.sql
>+++ b/installer/data/mysql/fr-FR/1-Obligatoire/message_transport_types.sql
>@@ -4,5 +4,4 @@ values
> ('print'),
> ('email'),
> ('sms'),
>-('feed'),
> ('phone');
>diff --git a/installer/data/mysql/it-IT/necessari/message_transport_types.sql b/installer/data/mysql/it-IT/necessari/message_transport_types.sql
>index bf4fd1b..eacb8e5 100644
>--- a/installer/data/mysql/it-IT/necessari/message_transport_types.sql
>+++ b/installer/data/mysql/it-IT/necessari/message_transport_types.sql
>@@ -6,7 +6,6 @@ values
> ('email'),
> ('print'),
> ('sms'),
>-('feed'),
> ('phone');
> 
> SET FOREIGN_KEY_CHECKS=1;
>diff --git a/installer/data/mysql/nb-NO/1-Obligatorisk/message_transport_types.sql b/installer/data/mysql/nb-NO/1-Obligatorisk/message_transport_types.sql
>index 9d9949e..6ff2f66 100644
>--- a/installer/data/mysql/nb-NO/1-Obligatorisk/message_transport_types.sql
>+++ b/installer/data/mysql/nb-NO/1-Obligatorisk/message_transport_types.sql
>@@ -25,5 +25,4 @@ values
> ('email'),
> ('print'),
> ('sms'),
>-('feed'),
> ('phone');
>diff --git a/installer/data/mysql/ru-RU/mandatory/message_transport_types.sql b/installer/data/mysql/ru-RU/mandatory/message_transport_types.sql
>index bf370c8..a789904 100644
>--- a/installer/data/mysql/ru-RU/mandatory/message_transport_types.sql
>+++ b/installer/data/mysql/ru-RU/mandatory/message_transport_types.sql
>@@ -6,5 +6,4 @@ values
> ('email'),
> ('print'),
> ('sms'),
>-('feed'),
> ('phone');
>diff --git a/installer/data/mysql/uk-UA/mandatory/message_transport_types.sql b/installer/data/mysql/uk-UA/mandatory/message_transport_types.sql
>index bf370c8..a789904 100644
>--- a/installer/data/mysql/uk-UA/mandatory/message_transport_types.sql
>+++ b/installer/data/mysql/uk-UA/mandatory/message_transport_types.sql
>@@ -6,5 +6,4 @@ values
> ('email'),
> ('print'),
> ('sms'),
>-('feed'),
> ('phone');
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 3f1af57..1b462f4 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -8603,6 +8603,36 @@ if ( CheckVersion($DBversion) ) {
>     SetVersion($DBversion);
> }
> 
>+$DBversion = "3.15.00.XXX";
>+if ( CheckVersion($DBversion) ) {
>+    my $count_l = $dbh->selectcol_arrayref(q|
>+        SELECT COUNT(*) FROM letter WHERE message_transport_type='feed'
>+    |);
>+    my $count_mq = $dbh->selectcol_arrayref(q|
>+        SELECT COUNT(*) FROM message_queue WHERE message_transport_type='feed'
>+    |);
>+    my $count_ott = $dbh->selectcol_arrayref(q|
>+        SELECT COUNT(*) FROM overduerules_transport_types WHERE message_transport_type='feed'
>+    |);
>+    my $count_mt = $dbh->selectcol_arrayref(q|
>+        SELECT COUNT(*) FROM message_transports WHERE message_transport_type='feed'
>+    |);
>+    my $count_bmtp = $dbh->selectcol_arrayref(q|
>+        SELECT COUNT(*) FROM borrower_message_transport_preferences WHERE message_transport_type='feed'
>+    |);
>+
>+    my $deleted = 0;
>+    if ( $count_l->[0] == 0 and $count_mq->[0] == 0 and $count_ott->[0] == 0 and $count_mt->[0] == 0 and $count_bmtp->[0] == 0 ) {
>+        $deleted = $dbh->do(q|
>+            DELETE FROM message_transport_types where message_transport_type='feed'
>+        |);
>+        $deleted = $deleted ne '0E0' ? 1 : 0;
>+    }
>+
>+    print "Upgrade to $DBversion done (Bug 12298: Delete the 'feed' message transport type " . ($deleted ? '(deleted!)' : '(not deleted)') . ")\n";
>+    SetVersion($DBversion);
>+}
>+
> =head1 FUNCTIONS
> 
> =head2 TableExists($table)
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12298: 28384 | 28385 | 30665 | 30672 | 30673