Bugzilla – Attachment 30802 Details for
Bug 10433
colspan calculation done by opac/opac-reserve.pl should be moved to template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template
PASSED-QA-Bug-10433---colspan-calculation-done-by-.patch (text/plain), 1.64 KB, created by
Katrin Fischer
on 2014-08-14 20:10:42 UTC
(
hide
)
Description:
[PASSED QA] Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-08-14 20:10:42 UTC
Size:
1.64 KB
patch
obsolete
>From 428106999e4a523202bdfeb8ba2a16bc276fd3c4 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 18 Jul 2014 08:55:00 -0400 >Subject: [PATCH] [PASSED QA] Bug 10433 - colspan calculation done by > opac/opac-reserve.pl should be moved to template > >Since the bootstrap OPAC's place hold interface doesn't use tables >there is no use for the colspan calculation being done in the script. >This patch removes it. > >To test, place one or more holds in the OPAC and confirm that there are >no display problems. The OPAC error logs should show no associated >error. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >No display problems, no related errors on log, no koha-qa errors > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes tests and QA script, no regressions found. >--- > opac/opac-reserve.pl | 10 ---------- > 1 file changed, 10 deletions(-) > >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 45d03bd..ec63976 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -565,18 +565,8 @@ if ( $numBibsAvailable == 0 || $anyholdable == 0) { > $template->param( none_available => 1 ); > } > >-my $itemTableColspan = 9; >-if (! $template->{VARS}->{'OPACItemHolds'}) { >- $itemTableColspan--; >-} >-if (! $template->{VARS}->{'singleBranchMode'}) { >- $itemTableColspan--; >-} >-$itemTableColspan-- if !$show_holds_count && !$show_priority; > my $show_notes=C4::Context->preference('OpacHoldNotes'); > $template->param(OpacHoldNotes=>$show_notes); >-$itemTableColspan-- if !$show_notes; >-$template->param(itemtable_colspan => $itemTableColspan); > > # display infos > $template->param(bibitemloop => $biblioLoop); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10433
:
30470
|
30650
| 30802