Attachment 30811 Details for Bug 11504 – Bug 11504: Untranslatable "Item Type" or "Collection Code" in branch transfer limits

[patch] Bug 11504: Untranslatable "Item Type" or "Collection Code" in branch transfer limits

Bug-11504-Untranslatable-Item-Type-or-Collection-C.patch (text/plain), 2.73 KB, created by Chris Cormack on 2014-08-15 02:06:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2014-08-15 02:06:02 UTC

Size: 2.73 KB

patch

obsolete

>From f94dedc7cc4641398dbfe722fa75a96682f7e902 Mon Sep 17 00:00:00 2001
>From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Date: Thu, 14 Aug 2014 19:46:57 -0300
>Subject: [PATCH] Bug 11504: Untranslatable "Item Type" or "Collection Code" in
> branch transfer limits
>
>This patch makes reported strings translatable.
>
>To test:
>1. Go to Administration > Library transfer limits
>
>2. Depending on the value of BranchTransferLimitsType
>your may see in a box:
>a) For *all* Collection codes:
>b) For *all* Item types:
>
>change system preference to show both values
>
>3. Update translation files for your preferred language
>check new entry
>msgid "%sCollection codes%sItem types%s: "
>
>Not pretty but can be translated.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> admin/branch_transfer_limits.pl                                   | 8 ++------
> .../intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt | 2 +-
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
>diff --git a/admin/branch_transfer_limits.pl b/admin/branch_transfer_limits.pl
>index 4aa41dd..f94f666 100755
>--- a/admin/branch_transfer_limits.pl
>+++ b/admin/branch_transfer_limits.pl
>@@ -64,12 +64,8 @@ for my $thisbranch (sort { $branches->{$a}->{branchname} cmp $branches->{$b}->{b
> }
> 
> 
>-# Set the template language for the correct limit type
>-my $limit_phrase = 'Collection Code';
>+# Set the template language for the correct limit type using $limitType
> my $limitType = C4::Context->preference("BranchTransferLimitsType") || "ccode";
>-if ( $limitType eq 'itemtype' ) {
>-	$limit_phrase = 'Item Type';
>-}
> 
> my @codes;
> my @branchcodes;
>@@ -143,7 +139,7 @@ $template->param(
> 		branchcode_loop => \@branchcode_loop,
> 		branchcode => $branchcode,
> 		branchname => $branchname,
>-		limit_phrase => $limit_phrase,
>+        limitType => $limitType,
> 		);
> 
> output_html_with_http_headers $input, $cookie, $template->output;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>index 5c10b0d..f9a7221 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>@@ -70,7 +70,7 @@
>     </form>
> 
> <p class="help">Check the boxes for the libraries you accept to checkin items from.</p>
>-<fieldset>For <strong>all</strong> [% limit_phrase %]s: <a id="CheckAll" href="#">Check all</a> | <a id="UncheckAll" href="#">Uncheck all</a></fieldset>
>+<fieldset>For <strong>all</strong> [% IF ( limitType == 'ccode' ) %]Collection codes[% ELSE %]Item types[% END %]: <a id="CheckAll" href="#">Check all</a> | <a id="UncheckAll" href="#">Uncheck all</a></fieldset>
> 
> 
>   <div id="transferlimit_tabs" class="toptabs">
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 11504: 30805 | 30811 | 30840