Bugzilla – Attachment 30856 Details for
Bug 4231
Placing holds from cart fails silently
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 4231 - Placing holds from cart fails silently
PASSED-QA-Bug-4231---Placing-holds-from-cart-fails.patch (text/plain), 1.69 KB, created by
Kyle M Hall (khall)
on 2014-08-15 17:17:19 UTC
(
hide
)
Description:
[PASSED QA] Bug 4231 - Placing holds from cart fails silently
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-08-15 17:17:19 UTC
Size:
1.69 KB
patch
obsolete
>From 88dbf465983e7b4471c78c372c512eb577205e69 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sun, 27 Jul 2014 20:30:47 +0200 >Subject: [PATCH] [PASSED QA] Bug 4231 - Placing holds from cart fails silently > >This patch adds a more meaningfull message if multiple biblios with no >items attached are in the cart. > >To test: >- Add biblios with and without items to cart >- Go to cart, select all and click 'Place hold' > >Without patch, message reads: >Cannot place hold: this record has no items attached. > >With patch, message reads: >Cannot place hold: one or more records without items attached. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/modules/reserve/request.tt | 10 +++++++--- > 1 files changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index cafc072..60551f4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -182,9 +182,13 @@ function checkMultiHold() { > <div id="yui-main"> > <div class="yui-b"> > [% IF ( noitems ) %] >-<div class="dialog alert"> >-<strong>Cannot place hold:</strong> this record has no items attached. >-</div> >+ <div class="dialog alert"> >+ [%IF (multi_hold) %] >+ <strong>Cannot place hold:</strong> one or more records without items attached. >+ [% ELSE %] >+ <strong>Cannot place hold:</strong> this record has no items attached. >+ [% END %] >+ </ div> > [% ELSE %] > [% IF ( messagetransfert ) %] > <div class="dialog message"> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4231
:
30653
|
30705
| 30856