Bugzilla – Attachment 30858 Details for
Bug 11614
Untranslatable label_element_title in label management
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11614: Untranslatable label_element_title in label management
PASSED-QA-Bug-11614-Untranslatable-labelelementtit.patch (text/plain), 3.31 KB, created by
Kyle M Hall (khall)
on 2014-08-15 17:38:28 UTC
(
hide
)
Description:
[PASSED QA] Bug 11614: Untranslatable label_element_title in label management
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-08-15 17:38:28 UTC
Size:
3.31 KB
patch
obsolete
>From c12e7641898f4b8adfbef3a8c571acd318aad369 Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Thu, 14 Aug 2014 21:07:04 -0300 >Subject: [PATCH] [PASSED QA] Bug 11614: Untranslatable label_element_title in label management > >This patch makes those strings translatable. >Title now depends on element, all on TT file, >removed from pl file > >To test: >1. Apply the patch >2. Go to Tools > Label creator >3. Clic on Manage layouts, templates, profilesor batches, >title of currently available must show with fixed >capitalization >4. Update translation languages and check new entries >msgid "Currently available batches" >msgid "Currently available layouts" >msgid "Currently available profiles" >msgid "Currently available templates > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/modules/labels/label-manage.tt | 10 +++++++++- > labels/label-manage.pl | 6 ------ > 2 files changed, 9 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt >index a5b1845..205990a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt >@@ -113,7 +113,15 @@ > <div class="hint">Current library: [% LoginBranchname %]</div> > [% IF ( table_loop ) %] > <form name="layouts" action="/cgi-bin/koha/label-manage.pl?label_element=[% label_element %]"> >- <h2>Currently Available [% label_element_title %]</h2> >+ [% IF ( label_element == 'layout' ) %] >+ <h2>Currently available layouts</h2> >+ [% ELSIF ( label_element == 'template' ) %] >+ <h2>Currently available templates</h2> >+ [% ELSIF ( label_element == 'profile' ) %] >+ <h2>Currently available profiles</h2> >+ [% ELSIF ( label_element == 'batch' ) %] >+ <h2>Currently available batches</h2> >+ [% END %] > <table id="labels-table"> > [% FOREACH table_loo IN table_loop %] > [% IF ( table_loo.header_fields ) %] >diff --git a/labels/label-manage.pl b/labels/label-manage.pl >index b92046c..061dea4 100755 >--- a/labels/label-manage.pl >+++ b/labels/label-manage.pl >@@ -98,12 +98,6 @@ $template->param( > element_id => $element_id, > table_loop => $table, > label_element => $label_element, >- label_element_title => ($label_element eq 'layout' ? 'Layouts' : >- $label_element eq 'template' ? 'Templates' : >- $label_element eq 'profile' ? 'Profiles' : >- $label_element eq 'batch' ? 'Batches' : >- '' >- ), > ); > > output_html_with_http_headers $cgi, $cookie, $template->output; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11614
:
30807
|
30809
| 30858