Attachment 30859 Details for Bug 8539 – [PASSED QA] Bug 8539: Library transfer limits page has incorrect permission

[patch] [PASSED QA] Bug 8539: Library transfer limits page has incorrect permission

PASSED-QA-Bug-8539-Library-transfer-limits-page-ha.patch (text/plain), 1.43 KB, created by Kyle M Hall (khall) on 2014-08-15 17:48:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-08-15 17:48:43 UTC

Size: 1.43 KB

patch

obsolete

>From 7e6a0e76c78c9125ba76b2e55f47f87ca6945b12 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Sat, 12 Jul 2014 14:22:53 +0200
>Subject: [PATCH] [PASSED QA] Bug 8539: Library transfer limits page has incorrect permission
>
>Without this patch the library transfer page required the
>'borrowers' permission, which is not quite right for a page
>in the administration module.
>
>This patch changes the permission to 'parameters_remaining_permissions'
>
>To test:
>Verify the page is accessbile with:
>- superlibrarian
>- administration (full)
>- administration, remaining permissions (without manage_circ_rules)
>Verify the page is not accessible without all of those permissions.
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> admin/branch_transfer_limits.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/admin/branch_transfer_limits.pl b/admin/branch_transfer_limits.pl
>index 4aa41dd..bd4cb24 100755
>--- a/admin/branch_transfer_limits.pl
>+++ b/admin/branch_transfer_limits.pl
>@@ -35,7 +35,7 @@ my ($template, $loggedinuser, $cookie)
>     = get_template_and_user({template_name => "admin/branch_transfer_limits.tt",
> 			     query => $input,
> 			     type => "intranet",
>-			     flagsrequired => {borrowers => 1},
>+                 flagsrequired => {parameters => 'parameters_remaining_permissions'},
> 			     debug => 1,
> 			     });
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8539: 29658 | 30645 | 30859