Bugzilla – Attachment 30877 Details for
Bug 12371
Links in every patron self-registration email points to a single borrower
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12371 - Links in every patron self-registration email points to a single borrower
Bug-12371---Links-in-every-patron-self-registratio.patch (text/plain), 1.85 KB, created by
Chris Cormack
on 2014-08-16 20:52:55 UTC
(
hide
)
Description:
Bug 12371 - Links in every patron self-registration email points to a single borrower
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2014-08-16 20:52:55 UTC
Size:
1.85 KB
patch
obsolete
>From f7905f5dd0e0df276e2de335ac9d6de8bc9598c0 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 15 Aug 2014 12:45:44 -0400 >Subject: [PATCH] Bug 12371 - Links in every patron self-registration email > points to a single borrower > >If multiple registrations are submitted, the first patron to register >will be used for the first patron to click the registration confirmation >link! > >Test Plan: >1) Submit 2 new patron registrations >2) Use the confirm link from the 2nd registration >3) Note you end up registering as the first submitted registration >4) Apply the patch >5) Repeat steps 1 and 2 >6) Note you are now confirmed correctly > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Test plan appears to work fine, I have a feeling the sql could be >written better but can't come up with it on a Sunday morning >--- > C4/Letters.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 1d916e0..2ce2b78 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -563,7 +563,7 @@ sub _parseletter_sth { > ($table eq 'aqbooksellers') ? "SELECT * FROM $table WHERE id = ?" : > ($table eq 'aqorders' ) ? "SELECT * FROM $table WHERE ordernumber = ?" : > ($table eq 'opac_news' ) ? "SELECT * FROM $table WHERE idnew = ?" : >- ($table eq 'borrower_modifications') ? "SELECT * FROM $table WHERE borrowernumber = ? OR verification_token =?": >+ ($table eq 'borrower_modifications') ? "SELECT * FROM $table WHERE ( borrowernumber = 0 OR borrowernumber = ? ) AND ( verification_token = '' OR verification_token = ? ) AND ( verification_token != '' OR borrowernumber != 0 )" : > undef ; > unless ($query) { > warn "ERROR: No _parseletter_sth query for table '$table'"; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12371
:
30850
|
30877
|
31037