Attachment 30896 Details for Bug 12453 – [PASSED QA] Bug 12453 - Do not use by default Host-Item-Number in UNIMARC

[patch] [PASSED QA] Bug 12453 - Do not use by default Host-Item-Number in UNIMARC

PASSED-QA-Bug-12453---Do-not-use-by-default-Host-I.patch (text/plain), 3.71 KB, created by Katrin Fischer on 2014-08-17 10:26:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-08-17 10:26:28 UTC

Size: 3.71 KB

patch

obsolete

>From 0b5ae6b8ad7a0ae1ec09578c52b3135993864735 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 19 Jun 2014 16:01:03 +0200
>Subject: [PATCH] [PASSED QA] Bug 12453 - Do not use by default
> Host-Item-Number in UNIMARC
>
>Actually, in default UNIMARC install, 461$9 is indexed as Host-Item-Number, meaning it is used for analytical itemnumber.
>
>But most UNIMARC catalog use the analytical relation using unimarc_field_4XX.pl plugin on 461$a. In fact, this plugin is defined in default UNIMARC frameworks.
>
>If Host-Item-Number is defined but 461$9 is used for something else, it will lead to odd bugs. For example, records containing analytical items can not be deleted.
>
>This patch comments the 461$9 indexing in UNIMARC zebra config.
>
>Test plan :
>- Create a fresh UNIMARC install
>- Create a record with 461$9 containing a value
>- Index the record
>- Perform a search on Host-Item-Number : ccl=Host-Item-Number,alwaysmatches=''
>=> Without the patch you get a result
>=> With the patch you get no result
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Code is clean, commenting out all the indexing of 461$9.
>Trusting the author that this is the correct thing to do :)
>---
> etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml  | 2 ++
> etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl | 7 -------
> etc/zebradb/marc_defs/unimarc/biblios/record.abs                 | 2 +-
> 3 files changed, 3 insertions(+), 8 deletions(-)
>
>diff --git a/etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml b/etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
>index e70a12c..aeeacc5 100644
>--- a/etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
>+++ b/etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
>@@ -910,9 +910,11 @@
>     <target_index>Host-item:w</target_index>
>     <target_index>Host-item:p</target_index>
>   </index_subfields>
>+  
>   
>   <index_subfields xmlns="http://www.koha-community.org/schemas/index-defs" tag="462" subfields="t">
>     <target_index>Title:w</target_index>
>diff --git a/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl b/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
>index c1a41aa..46f106d 100644
>--- a/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
>+++ b/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
>@@ -1425,13 +1425,6 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml)
>         </z:index>
>       </xslo:if>
>     </xslo:for-each>
>-    <xslo:for-each select="marc:subfield">
>-      <xslo:if test="contains('9', @code)">
>-        <z:index name="Host-Item-Number:w">
>-          <xslo:value-of select="."/>
>-        </z:index>
>-      </xslo:if>
>-    </xslo:for-each>
>   </xslo:template>
>   <xslo:template mode="index_subfields" match="marc:datafield[@tag='462']">
>     <xslo:for-each select="marc:subfield">
>diff --git a/etc/zebradb/marc_defs/unimarc/biblios/record.abs b/etc/zebradb/marc_defs/unimarc/biblios/record.abs
>index 4fadcc1..fcf4034 100644
>--- a/etc/zebradb/marc_defs/unimarc/biblios/record.abs
>+++ b/etc/zebradb/marc_defs/unimarc/biblios/record.abs
>@@ -380,7 +380,7 @@ melm 488$t    Title,Title:p
> 
> # Linking ids (Koha analytics)
> # FIXME Warning : field used by Koha for analytics, but also in Sudoc network
>-melm 461$9    Host-Item-Number
>+# melm 461$9    Host-Item-Number
> 
> ############## 5XX - TITLES ##################
> melm 500$9    Koha-Auth-Number,Koha-Auth-Number:n
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12453: 29040 | 30261 | 30896