Attachment 30923 Details for Bug 7817 – [SIGNED_OFF ORIGINAL] Bug 7817 - Items Permanent location (shelving location) is set to NULL when item is edited

[patch] [SIGNED_OFF ORIGINAL] Bug 7817 - Items Permanent location (shelving location) is set to NULL when item is edited

Bug-7817---Items-Permanent-location-shelving-locat.patch (text/plain), 1.42 KB, created by Marcel de Rooy on 2014-08-18 11:12:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2014-08-18 11:12:41 UTC

Size: 1.42 KB

patch

obsolete

>From e83f1cd3ecbda1a2abeef5137f07498fe7841f9e Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Wed, 18 Jun 2014 18:31:13 +0300
>Subject: [PATCH] Bug 7817 - Items Permanent location (shelving location) is
> set to NULL when item is edited
>Content-Type: text/plain; charset=utf-8
>
>A quick fix to prevent more damages.
>No perceived side-effects so far.
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>
>This is actually a perfectly good fix for this issue. I've changed
>the explanatory comment to explain why.
>
>Another option would be to remove the 'exists' check in the sub
>_do_column_fixes_for_mod(), but this is just as functional.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Detailed comment on Bugzilla.
>Adding a small follow-up.
>---
> C4/Items.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index f8e2121..f5ffada 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -459,7 +459,7 @@ my %default_values_for_mod_from_marc = (
>     itemnotes            => undef, 
>     itype                => undef, 
>     location             => undef, 
>-    permanent_location   => undef,
>+#    permanent_location   => undef, # "undef" counts as "exists" which disrupts proper handling of location and permanent_location in _do_column_fixes_for_mod()
>     materials            => undef, 
>     notforloan           => 0,
>     paidfor              => undef, 
>-- 
>1.7.7.6

Actions: View | Diff | Splinter Review

Attachments on bug 7817: 28949 | 28970 | 28971 | 29093 | 30350 | 30923 | 30924 | 31133 | 31134 | 31464