Attachment 30996 Details for Bug 9011 – [SIGNED OFF] Bug 9011 [QA Followup]

[patch] [SIGNED OFF] Bug 9011 [QA Followup]

SIGNED-OFF-Bug-9011-QA-Followup.patch (text/plain), 983 bytes, created by Nick Clemens (kidclamp) on 2014-08-19 20:19:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2014-08-19 20:19:35 UTC

Size: 983 bytes

patch

obsolete

>From cd88cff40a586a2c66f10ed135941d18e942be15 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 26 Jun 2014 14:55:50 -0400
>Subject: [PATCH] [SIGNED OFF] Bug 9011 [QA Followup]
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>---
> C4/Circulation.pm |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 979f77a..832b7b4 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3101,7 +3101,8 @@ sub AnonymiseIssueHistory {
>     }
> 
>     if ( C4::Context->preference('StoreLastBorrower') ) {
>-        $query .= " AND issue_id IN ( SELECT issue_id FROM old_issues GROUP BY itemnumber ORDER BY issue_id DESC ) ";
>+        # Do not delete the newest old_issue for any itemnumber
>+        $query .= " AND issue_id NOT IN ( SELECT issue_id FROM ( SELECT * FROM old_issues ORDER BY issue_id DESC ) AS oi GROUP BY itemnumber ) ";
>     }
> 
>     my $sth = $dbh->prepare($query);
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 9011: 13258 | 15117 | 15200 | 16666 | 16763 | 16773 | 18676 | 20180 | 20181 | 20329 | 20342 | 20343 | 20344 | 22577 | 22578 | 22579 | 25866 | 25867 | 25868 | 25869 | 25870 | 25871 | 25872 | 25873 | 28923 | 28924 | 28925 | 29301 | 29745 | 29749 | 29750 | 29930 | 29931 | 30979 | 30993 | 30994 | 30995 | 30996 | 30997 | 30998 | 30999 | 32430 | 32431 | 32432 | 32433 | 32434 | 32435 | 32436 | 32437 | 32438 | 32439 | 32440 | 32441 | 32442 | 32443 | 32977 | 37113 | 37114 | 37115 | 37116 | 37117 | 38441 | 38442 | 38443 | 38444 | 38445 | 39812 | 39813 | 39814 | 39815 | 39816