Attachment 31020 Details for Bug 12782 – Bug 12782: t/db_dependent/XISBN.t fails in DOM setup

[patch] Bug 12782: t/db_dependent/XISBN.t fails in DOM setup

Bug-12782-tdbdependentXISBNt-fails-in-DOM-setup.patch (text/plain), 1.36 KB, created by Jonathan Druart on 2014-08-20 11:18:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-08-20 11:18:00 UTC

Size: 1.36 KB

patch

obsolete

>From f81f9aaa37127cf10ce871db016abced3efd13e9 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Mon, 18 Aug 2014 16:42:39 -0300
>Subject: [PATCH] Bug 12782: t/db_dependent/XISBN.t fails in DOM setup
>
>To test:
>- Have a DOM setup
>- Run
>  $ prove -v t/db_dependent/XISBN.t
>=> FAIL: Can't call method "field" on an undefined value at .... C4/Search.pm ...
>- Apply the patch
>- Run
>  $ prove -v t/db_dependent/XISBN.t
>=> SUCCESS: Tests pass.
>- Sign off
>
>Regards
>To+
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> t/db_dependent/XISBN.t | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/XISBN.t b/t/db_dependent/XISBN.t
>index 34f353a..1f6f797 100755
>--- a/t/db_dependent/XISBN.t
>+++ b/t/db_dependent/XISBN.t
>@@ -10,6 +10,7 @@ use MARC::Record;
> use C4::Biblio;
> use C4::XISBN;
> use C4::Context;
>+use C4::Search;
> use Test::MockModule;
> 
> BEGIN {
>@@ -113,6 +114,10 @@ sub Mock_SimpleSearch {
>     }
>     $record->append_fields($biblionumber_field);
> 
>-    push @results, $record->as_usmarc;
>+    my $indexing_mode = C4::Context->config('zebra_bib_index_mode') // 'dom';
>+    push @results, ( $indexing_mode eq 'dom' )
>+                    ? $record->as_xml()
>+                    : $record->as_usmarc() ;
>+
>     return ( undef, \@results, 1 );
> }
>-- 
>2.0.0.rc2

Actions: View | Diff | Splinter Review

Attachments on bug 12782: 30951 | 30952 | 30970 | 30971 | 31020 | 31021