Bugzilla – Attachment 31034 Details for
Bug 12505
Make variable aqorders.listprice in acq claim notice work and improve error handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
This patch removes the unnecessary join
Bug-12505---Variable-aqorderslistprice-from-Tools-.patch (text/plain), 1.97 KB, created by
simith.doliveira
on 2014-08-20 19:40:56 UTC
(
hide
)
Description:
This patch removes the unnecessary join
Filename:
MIME Type:
Creator:
simith.doliveira
Created:
2014-08-20 19:40:56 UTC
Size:
1.97 KB
patch
obsolete
>From 84de1dfc31f8b9831cbac19bf77696670d811c56 Mon Sep 17 00:00:00 2001 >From: simith <simith@inlibro.com> >Date: Wed, 20 Aug 2014 15:33:15 -0400 >Subject: [PATCH] Bug 12505 - Variable aqorders.listprice from 'Tools' - > 'Notices and Slips' Does not work > >Modified: > >C4/Letters.pm - remove aqbooksellers.* from SELECT statement > >In Letters - SendAlerts subrotine, is safe to remove aqbooksellers.* from SELECT statement >for type=claimacquisition or claimissues. Aqbooksellers is passed to GetPreparedLetter subrotine in tables variable. > >Testing: > >I Apply the patch > >Select Tools -> Notices and slips; >Edit ACQCLAIM; >Add : ><order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered) ($<<aqorders.listprice>> <<aqbooksellers.listprice>> each) has not been received.</order> >Save modifications; >Create a vendor (Acquisition module); >Create an order (Acquisition module); >Click Acquisitions -> Late orders; >Select the order created; >Click Claim order button; >Valide <<aqorders.listprice>>; >Valide <<aqbooksellers.listprice>>. >--- > C4/Letters.pm | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index a3fcbb7..d456dc7 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -299,13 +299,11 @@ sub SendAlerts { > # search the biblionumber > my $strsth = $type eq 'claimacquisition' > ? qq{ >- SELECT aqorders.*,aqbasket.*,biblio.*,biblioitems.*,aqbooksellers.*, >- aqbooksellers.id AS booksellerid >+ SELECT aqorders.*,aqbasket.*,biblio.*,biblioitems.* > FROM aqorders > LEFT JOIN aqbasket ON aqbasket.basketno=aqorders.basketno > LEFT JOIN biblio ON aqorders.biblionumber=biblio.biblionumber > LEFT JOIN biblioitems ON aqorders.biblionumber=biblioitems.biblionumber >- LEFT JOIN aqbooksellers ON aqbasket.booksellerid=aqbooksellers.id > WHERE aqorders.ordernumber IN ( > } > : qq{ >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12505
:
29382
|
31034
|
33527
|
33562
|
33602
|
33603