Attachment 31037 Details for Bug 12371 – [PASSED QA] Bug 12371 - Links in every patron self-registration email points to a single borrower

[patch] [PASSED QA] Bug 12371 - Links in every patron self-registration email points to a single borrower

PASSED-QA-Bug-12371---Links-in-every-patron-self-r.patch (text/plain), 1.99 KB, created by Katrin Fischer on 2014-08-21 07:16:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-08-21 07:16:28 UTC

Size: 1.99 KB

patch

obsolete

>From 9f5f9d88612654bd13ea2bd1abdddf94570d746d Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 15 Aug 2014 12:45:44 -0400
>Subject: [PATCH] [PASSED QA] Bug 12371 - Links in every patron
> self-registration email points to a single borrower
>
>If multiple registrations are submitted, the first patron to register
>will be used for the first patron to click the registration confirmation
>link!
>
>Test Plan:
>1) Submit 2 new patron registrations
>2) Use the confirm link from the 2nd registration
>3) Note you end up registering as the first submitted registration
>4) Apply the patch
>5) Repeat steps 1 and 2
>6) Note you are now confirmed correctly
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Test plan appears to work fine, I have a feeling the sql could be
>written better but can't come up with it on a Sunday morning
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works as described and fixes a critical bug.
>Passes tests and QA script.
>---
> C4/Letters.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 1d916e0..2ce2b78 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -563,7 +563,7 @@ sub _parseletter_sth {
>     ($table eq 'aqbooksellers') ? "SELECT * FROM $table WHERE             id = ?"                                  :
>     ($table eq 'aqorders'     ) ? "SELECT * FROM $table WHERE    ordernumber = ?"                                  :
>     ($table eq 'opac_news'    ) ? "SELECT * FROM $table WHERE          idnew = ?"                                  :
>-    ($table eq 'borrower_modifications') ? "SELECT * FROM $table WHERE borrowernumber = ? OR verification_token =?":
>+    ($table eq 'borrower_modifications') ? "SELECT * FROM $table WHERE ( borrowernumber = 0 OR borrowernumber = ? ) AND ( verification_token = '' OR verification_token = ? ) AND ( verification_token != '' OR borrowernumber != 0 )" :
>     undef ;
>     unless ($query) {
>         warn "ERROR: No _parseletter_sth query for table '$table'";
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12371: 30850 | 30877 | 31037