Bugzilla – Attachment 31053 Details for
Bug 12801
Koha::Calendar is caching holidays for the wrong branch!
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12801 - Remove caching
Bug-12801---Remove-caching.patch (text/plain), 1.05 KB, created by
Kyle M Hall (khall)
on 2014-08-21 13:49:19 UTC
(
hide
)
Description:
Bug 12801 - Remove caching
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-08-21 13:49:19 UTC
Size:
1.05 KB
patch
obsolete
>From 15c617da23dbe0d12697383f7ece900de0b997cd Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 21 Aug 2014 09:48:20 -0400 >Subject: [PATCH] Bug 12801 - Remove caching > >This patch removes the special holiday caching which fixes the bug, >but causes a different unit test to fail. I do not no if the failing >unit test is valid. If it is, this patch will cause a regression. If it >is not valid, the test should be removed. >--- > Koha/Calendar.pm | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > >diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm >index 276c7ce..ba20f0d 100644 >--- a/Koha/Calendar.pm >+++ b/Koha/Calendar.pm >@@ -92,10 +92,6 @@ sub single_holidays { > my ( $self ) = @_; > my $dbh = C4::Context->dbh; > my $branch = $self->{branchcode}; >- if ( $single_holidays ) { >- $self->{single_holidays} = $single_holidays; >- return $single_holidays; >- } > my $single_holidays_sth = $dbh->prepare( > 'SELECT day, month, year FROM special_holidays WHERE branchcode = ? AND isexception = 0' > ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12801
:
31052
|
31053
|
31056
|
31075
|
32514
|
32515
|
32516