Attachment 3108 Details for Bug 5725 – Proposed Patch

[patch] Proposed Patch

0002-Bug-5725-follow-up.patch (text/plain), 1.58 KB, created by Chris Cormack on 2011-02-09 01:13:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2011-02-09 01:13:30 UTC

Size: 1.58 KB

patch

obsolete

>From 5d094c192abbefc478260871e483bf1fcae248c4 Mon Sep 17 00:00:00 2001
>From: Paul Poulain <paul.poulain@biblibre.com>
>Date: Mon, 10 Jan 2011 17:22:31 +0100
>Subject: [PATCH 2/2] Bug 5725 follow up
>
>Owen noticed the batchedit was not working. This was because we made a patch months ago to change the GetBiblio API
>(the 1st returned arg is useless)
>This patch is not in main trunk, resulting in the error owen has noticed.
>
>This patch goes back to official API (even if it is clumsy : the patch we did does not apply anymore)
>---
> tools/batchedit.pl |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/tools/batchedit.pl b/tools/batchedit.pl
>index 06fcd0f..8bf01b6 100755
>--- a/tools/batchedit.pl
>+++ b/tools/batchedit.pl
>@@ -175,7 +175,7 @@ if($input->param('field') and not defined $op){
>         my @repvals    = $input->param('repval');
>         foreach my $biblionumber ( @biblionumbers ){
>             my $record = GetMarcBiblio($biblionumber);
>-            my $biblio = GetBiblio($biblionumber);
>+            my ($count, $biblio) = GetBiblio($biblionumber);
>             my $report = 0;
>             my @failed_actions;
>             for(my $i = 0 ; $i < scalar(@fields) ; $i++ ){
>@@ -209,7 +209,7 @@ if($input->param('field') and not defined $op){
> my @biblioinfos;
> 
> for my $biblionumber (@biblionumbers){
>-    my $biblio = GetBiblio($biblionumber);
>+    my ($count,$biblio) = GetBiblio($biblionumber);
>     if (defined $op){
>         $biblio->{$report_actions{$biblionumber}->{status}}=1;
>         $biblio->{failed_actions}=$report_actions{$biblionumber}->{failed_actions};
>-- 
>1.7.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 5725: 3105 | 3108 | 3191 | 3193 | 3234 | 3356 | 4734 | 4735 | 4736 | 4863 | 4864 | 4897 | 4898 | 4899 | 5404 | 5405 | 5684 | 5685 | 5697 | 5959 | 5960 | 5980 | 5981 | 5982 | 10610 | 10611 | 10612 | 11731 | 11732 | 11733