Attachment 31099 Details for Bug 11633 – [PASSED QA] Bug 11633 : Block Issue if fines require staff override

[patch] [PASSED QA] Bug 11633 : Block Issue if fines require staff override

PASSED-QA-Bug-11633--Block-Issue-if-fines-require-.patch (text/plain), 1.63 KB, created by Kyle M Hall (khall) on 2014-08-22 14:59:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-08-22 14:59:29 UTC

Size: 1.63 KB

patch

obsolete

>From c58fe3ec7e93a6ff0d5cbe065fc71891b870a668 Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Thu, 17 Apr 2014 15:55:03 +0100
>Subject: [PATCH] [PASSED QA] Bug 11633 : Block Issue if fines require staff override
>
>If a patrons fines exceed noissuescharge and we allow
>staff to allow issue at their discretion via an override
>the SIP process allowed charges to go ahead.
>This patch closes the loophole which allowed self issue
>to subvert the usual library loan policy
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/SIP/ILS/Transaction/Checkout.pm |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/C4/SIP/ILS/Transaction/Checkout.pm b/C4/SIP/ILS/Transaction/Checkout.pm
>index c61eca6..edc1d04 100644
>--- a/C4/SIP/ILS/Transaction/Checkout.pm
>+++ b/C4/SIP/ILS/Transaction/Checkout.pm
>@@ -85,7 +85,9 @@ sub do_checkout {
>             } elsif ($confirmation eq 'ISSUED_TO_ANOTHER') {
>                 $self->screen_msg("Item already checked out to another patron.  Please return item for check-in.");
>                 $noerror = 0;
>-            } elsif ($confirmation eq 'DEBT') {     # don't do anything, it's the minor debt, and alarms fire elsewhere
>+            } elsif ($confirmation eq 'DEBT') {
>+                $self->screen_msg('Outstanding Fines block issue');
>+                $noerror = 0;
>             } elsif ($confirmation eq 'HIGHHOLDS') {
>                 $overridden_duedate = $needsconfirmation->{$confirmation}->{returndate};
>                 $self->screen_msg('Loan period reduced for high-demand item');
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11633: 27258 | 27259 | 30731 | 30732 | 31099 | 31100