Bugzilla – Attachment 31136 Details for
Bug 12820
SIP2 does not send rental charge fee!
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12820 - SIP2 does not send rental charge fee!
Bug-12820---SIP2-does-not-send-rental-charge-fee.patch (text/plain), 1.34 KB, created by
Kyle M Hall (khall)
on 2014-08-25 12:32:52 UTC
(
hide
)
Description:
Bug 12820 - SIP2 does not send rental charge fee!
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-08-25 12:32:52 UTC
Size:
1.34 KB
patch
obsolete
>From b6e60a86748a40550e77ad49988969b3ebc3b954 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 25 Aug 2014 08:30:09 -0400 >Subject: [PATCH] Bug 12820 - SIP2 does not send rental charge fee! > >Koha's SIP2 implementation has facilities to send the fee amount ( BV ) >for checking out a given item, but in our code, the fee amount is never >set! > >Test Plan: >1) Check out an item with a rental fee via SIP2. >2) Note the BV field is missing. >3) Apply this patch, restart your SIP2 server. >4) Repeat step 1. >5) Note the BV field is now set to the correct value. >--- > C4/SIP/ILS/Item.pm | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > >diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm >index 7f144a8..991ac1d 100644 >--- a/C4/SIP/ILS/Item.pm >+++ b/C4/SIP/ILS/Item.pm >@@ -92,7 +92,10 @@ sub new { > > my $it = C4::Context->preference('item-level_itypes') ? $item->{itype} : $item->{itemtype}; > my $itemtype = Koha::Database->new()->schema()->resultset('Itemtype')->find( $it ); >- $item->{sip_media_type} = $itemtype->sip_media_type() if $itemtype; >+ if ($itemtype) { >+ $item->{sip_media_type} = $itemtype->sip_media_type(); >+ $item->{fee} = $itemtype->rentalcharge(); >+ } > > # check if its on issue and if so get the borrower > my $issue = GetItemIssue($item->{'itemnumber'}); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12820
:
31136
|
31153
|
33901
|
33902
|
33911
|
33994
|
35878
|
36155
|
37038
|
37039