Bugzilla – Attachment 31146 Details for
Bug 11431
Custom notification sounds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 11431 [2] - Rename soundon to AudioAlerts, move to it's own preference section
SIGNED-OFF-Bug-11431-2---Rename-soundon-to-AudioAl.patch (text/plain), 5.45 KB, created by
Nick Clemens (kidclamp)
on 2014-08-25 16:40:32 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 11431 [2] - Rename soundon to AudioAlerts, move to it's own preference section
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2014-08-25 16:40:32 UTC
Size:
5.45 KB
patch
obsolete
>From 9b75109625b5acc00c7f6b5ae5944c4e21878fb0 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 19 Jun 2014 08:21:43 -0400 >Subject: [PATCH] [SIGNED OFF] Bug 11431 [2] - Rename soundon to AudioAlerts, > move to it's own preference section > >Signed-off-by: Nick Clemens <nick@quecheelibrary.org> >--- > circ/circulation.pl | 2 +- > circ/returns.pl | 2 +- > installer/data/mysql/sysprefs.sql | 2 +- > installer/data/mysql/updatedatabase.pl | 8 ++++++++ > .../intranet-tmpl/prog/en/includes/doc-head-close.inc | 2 +- > .../prog/en/modules/admin/preferences/circulation.pref | 13 +++++++------ > 6 files changed, 19 insertions(+), 10 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index c766e88..97e0ef3 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -542,7 +542,7 @@ $template->param( > inprocess => $inprocess, > is_child => ($borrowernumber && $borrower->{'category_type'} eq 'C'), > circview => 1, >- soundon => C4::Context->preference("SoundOn"), >+ AudioAlerts => C4::Context->preference("AudioAlerts"), > fast_cataloging => $fast_cataloging, > CircAutoPrintQuickSlip => C4::Context->preference("CircAutoPrintQuickSlip"), > activeBorrowerRelationship => (C4::Context->preference('borrowerRelationship') ne ''), >diff --git a/circ/returns.pl b/circ/returns.pl >index d99f58c..0d67b46 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -596,7 +596,7 @@ $template->param( > dropboxmode => $dropboxmode, > dropboxdate => output_pref($dropboxdate), > overduecharges => $overduecharges, >- soundon => C4::Context->preference("SoundOn"), >+ AudioAlerts => C4::Context->preference("AudioAlerts"), > BlockReturnOfWithdrawnItems => C4::Context->preference("BlockReturnOfWithdrawnItems"), > ); > >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 7eb08a8..8026818 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -363,7 +363,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('SlipCSS','',NULL,'Slips CSS url.','free'), > ('SMSSendDriver','','','Sets which SMS::Send driver is used to send SMS messages.','free'), > ('SocialNetworks','0','','Enable/Disable social networks links in opac detail pages','YesNo'), >-('soundon','0','','Enable circulation sounds during checkin and checkout in the staff interface. Not supported by all web browsers yet.','YesNo'), >+('AudioAlerts','0','','Enable circulation sounds during checkin and checkout in the staff interface. Not supported by all web browsers yet.','YesNo'), > ('SpecifyDueDate','1','','Define whether to display \"Specify Due Date\" form in Circulation','YesNo'), > ('SpecifyReturnDate',1,'','Define whether to display \"Specify Return Date\" form in Circulation','YesNo'), > ('SpineLabelAutoPrint','0','','If this setting is turned on, a print dialog will automatically pop up for the quick spine label printer.','YesNo'), >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index de77bf3..24e6cff 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -8613,6 +8613,14 @@ if ( CheckVersion($DBversion) ) { > SetVersion($DBversion); > } > >+$DBversion = "3.17.00.XXX"; >+if ( CheckVersion($DBversion) ) { >+ $dbh->do(q{UPDATE systempreferences SET variable = 'AudioAlerts' WHERE variable = 'soundon'}); >+ >+ print "Upgrade to $DBversion done (Bug 11169 - Add OPACAcquisitionDetails syspref)\n"; >+ SetVersion($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >index d9f9171..9a0b9f5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc >@@ -62,7 +62,7 @@ > </script> > [% END %] > >-[% IF soundon %] >+[% IF AudioAlerts %] > <script type="text/javascript"> > //<![CDATA[ > var TMPL_SOUND_PATH = "[% interface %]/[% theme %]/sound/"; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 37c368c..94a52ec 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -40,12 +40,6 @@ Circulation: > desc: latest to earliest > - due date. > - >- - pref: soundon >- choices: >- yes: "Enable" >- no: "Don't enable" >- - circulation sounds during checkin and checkout in the staff interface. Not supported by all web browsers yet. >- - > - pref: SpecifyDueDate > choices: > yes: Allow >@@ -625,3 +619,10 @@ Circulation: > yes: Use > no: "Don't use" > - course reserves >+ Audio Alerts: >+ - >+ - pref: AudioAlerts >+ choices: >+ yes: "Enable" >+ no: "Don't enable" >+ - circulation sounds during checkin and checkout in the staff interface. Not supported by all web browsers yet. >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11431
:
29030
|
29031
|
29032
|
29033
|
29034
|
29035
|
29036
|
29037
|
29038
|
29039
|
29119
|
29120
|
29404
|
29764
|
29765
|
29766
|
29767
|
29768
|
29769
|
31145
|
31146
|
31147
|
31148
|
31149
|
31150
|
34637
|
34638
|
34639
|
34640
|
34641
|
34642
|
34643
|
34644
|
34645
|
34646
|
34647
|
34648
|
34649
|
34650
|
34651
|
34652
|
34653
|
34717
|
34718
|
34719
|
34720
|
34864
|
34865
|
34866
|
34867
|
35843
|
35844
|
35845
|
35846
|
38547
|
38548
|
40726
|
40727
|
40728
|
40729
|
40730
|
40731
|
40732
|
41634
|
41661
|
41662
|
42678
|
42679
|
42680
|
42681
|
42682
|
42683
|
42684
|
42685
|
42686
|
42687
|
42688
|
42689
|
42696
|
43753
|
43754
|
43755
|
43756
|
43757
|
43758
|
43759
|
43760
|
43761
|
43762
|
43763
|
43764
|
43765
|
43817
|
43820
|
43821
|
43822
|
43823
|
43824
|
43825
|
43887
|
43888
|
43889
|
43890
|
43891
|
43892
|
43893
|
43894
|
43895
|
43896
|
43897
|
43898
|
43899
|
43900
|
43901
|
43902
|
43903
|
44391
|
44392
|
44393
|
44394
|
44395
|
44396
|
44397
|
44398
|
44399
|
44400
|
44401
|
44402
|
44404
|
44405
|
44407
|
44408
|
44409
|
44411
|
44412
|
44599
|
45135