Bugzilla – Attachment 31163 Details for
Bug 12717
Library no longer receiving Overdue email for patrons without email address
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12717: Library no longer receiving Overdue email for patrons without email address
PASSED-QA-Bug-12717-Library-no-longer-receiving-Ov.patch (text/plain), 3.13 KB, created by
Katrin Fischer
on 2014-08-26 15:30:45 UTC
(
hide
)
Description:
[PASSED QA] Bug 12717: Library no longer receiving Overdue email for patrons without email address
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-08-26 15:30:45 UTC
Size:
3.13 KB
patch
obsolete
>From 7a9f1d2b9497f30a2c2ed912400ca46e9eaeb58a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 20 Aug 2014 13:26:49 +0200 >Subject: [PATCH] [PASSED QA] Bug 12717: Library no longer receiving Overdue > email for patrons without email address > >Bug 10832 changes the fallback behavior if a patron does not have email >address: a print notice is generated into the message_queue table. >But this can cause issue for some libraries. The script should sent an >email and (generated csv, html, text file) with the list of all unsent >notices. > >Test plan: >1/ Add overdue to a patron without email address (or smsalertnumber) >2/ Check email in the overdue rules configuration (or sms) >3/ Launch the overdue_notices.pl cronjob >4/ Verify the message_queue contain a print notice AND an email notice >for the library > >Signed-off-by: Nick Clemens <nick@quecheelibrary.org> >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >This works as described and restores the old behaviour for now, with >the difference that you have a print notice generated and visible >in the patron account notices tab that will say 'pending'. > >We will have to figure out how we can change the workflows nicely >to have only one script deal with print notice in the future. >--- > misc/cronjobs/overdue_notices.pl | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index a0a1254..942cb6a 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -692,6 +692,23 @@ END_SQL > if ( ($mtt eq 'email' and not scalar @emails_to_use) or ($mtt eq 'sms' and not $data->{smsalertnumber}) ) { > # email or sms is requested but not exist, do a print. > $mtt = 'print'; >+ push @output_chunks, >+ prepare_letter_for_printing( >+ { letter => $letter, >+ borrowernumber => $borrowernumber, >+ firstname => $data->{'firstname'}, >+ lastname => $data->{'surname'}, >+ address1 => $data->{'address'}, >+ address2 => $data->{'address2'}, >+ city => $data->{'city'}, >+ postcode => $data->{'zipcode'}, >+ country => $data->{'country'}, >+ email => $notice_email, >+ itemcount => $itemcount, >+ titles => $titles, >+ outputformat => defined $csvfilename ? 'csv' : defined $htmlfilename ? 'html' : defined $text_filename ? 'text' : '', >+ } >+ ); > } > unless ( $mtt eq 'print' and $print_sent == 1 ) { > # Just sent a print if not already done. >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12717
:
31022
|
31124
| 31163