Attachment 31195 Details for Bug 6536 – Bug 6536: QA Follow-up for removing warnings from QA tools

[patch] Bug 6536: QA Follow-up for removing warnings from QA tools

Bug-6536-QA-Follow-up-for-removing-warnings-from-Q.patch (text/plain), 1.07 KB, created by Marcel de Rooy on 2014-08-27 15:25:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2014-08-27 15:25:14 UTC

Size: 1.07 KB

patch

obsolete

>From 17fc2be53b7f7da87f71e0e40b4ad79ceea304e4 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 27 Aug 2014 16:56:11 +0200
>Subject: [PATCH] Bug 6536: QA Follow-up for removing warnings from QA tools
>Content-Type: text/plain; charset=utf-8
>
>Resolved:
>[1]  FAIL   C4/Breeding.pm
>FAIL   critic ControlStructures::ProhibitMutatingListFunctions
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>No warnings anymore.
>---
> C4/Breeding.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Breeding.pm b/C4/Breeding.pm
>index 293b933..fa3af82 100644
>--- a/C4/Breeding.pm
>+++ b/C4/Breeding.pm
>@@ -363,7 +363,7 @@ sub _create_connection {
>             #first remove surrounding spaces at comma and equals-sign
>             s/^\s+|\s+$//g;
>             my @temp= split '=', $_, 2;
>-            @temp= map { s/^\s+|\s+$//g; $_; } @temp;
>+            @temp= map { my $c=$_; $c=~s/^\s+|\s+$//g; $c; } @temp;
>             $option1->option( $temp[0] => $temp[1] ) if @temp;
>         }
>     } elsif( $server->{servertype} eq 'zed' ) {
>-- 
>1.7.7.6

Actions: View | Diff | Splinter Review

Attachments on bug 6536: 4540 | 4541 | 4959 | 6901 | 6919 | 6920 | 6924 | 13462 | 26169 | 26170 | 26171 | 26172 | 29754 | 29755 | 29756 | 29779 | 29780 | 29788 | 29790 | 29791 | 29812 | 29813 | 29814 | 29815 | 29816 | 29817 | 29818 | 29819 | 30189 | 30190 | 30191 | 30192 | 30193 | 30194 | 30900 | 30901 | 30902 | 30903 | 30904 | 30905 | 30906 | 30907 | 30929 | 30930 | 30931 | 30932 | 30933 | 30934 | 30935 | 30936 | 31046 | 31048 | 31137 | 31193 | 31194 | 31195 | 31227 | 31247 | 31248 | 37264