Bugzilla – Attachment 31276 Details for
Bug 12851
order tags are not removed on claiming serials/orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12851: order tags should be removed from the claiming letter
Bug-12851-order-tags-should-be-removed-from-the-cl.patch (text/plain), 1.40 KB, created by
Jonathan Druart
on 2014-08-29 13:00:35 UTC
(
hide
)
Description:
Bug 12851: order tags should be removed from the claiming letter
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-08-29 13:00:35 UTC
Size:
1.40 KB
patch
obsolete
>From e75b565d3c3c9a9814a807d53ddd704931808bb4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 29 Aug 2014 14:56:54 +0200 >Subject: [PATCH] Bug 12851: order tags should be removed from the claiming > letter > >If you use a claimissue notice to claim serials, the generated letter >will be > ><order>Title1, Author1</order> ><order>Title2, Author2</order> >... ><order>TitleN, AuthorN</order> > >This patch geds rid of these tags. > >Test plan: >1/ Create a claimissue notice with something like: > <<LibrarianFirstname>> > <<LibrarianSurname>> > The following issues are in late: > <order><<biblio.title>>, <<biblio.author>> (<<biblio.serial>>)</order> > >2/ Generated late serial issues. >3/ Send notifications to vendor. >4/ The order tags should not exist anymore in the sent email. > >You can see bug 5342 for a more detailled test plan. > >Note for QA: This should have been done in GetPreparedLetter, but I did >not find a better way to do. >--- > C4/Letters.pm | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 912294e..7adde83 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -359,6 +359,9 @@ sub SendAlerts { > want_librarian => 1, > ) or return; > >+ # Remove the order tag >+ $letter->{content} =~ s/<order>(.*?)<\/order>/$1/gxms; >+ > # ... then send mail > my %mail = ( > To => join( ',', @email), >-- >2.0.0.rc2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12851
:
31276
|
33264
|
33739
|
33770
|
33924