Bugzilla – Attachment 31287 Details for
Bug 12674
GetMarcISSN should not return empty ISSN
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN
PASSED-QA-Bug-12674-regression-tests-GetMarcISSN-s.patch (text/plain), 1.69 KB, created by
Kyle M Hall (khall)
on 2014-08-29 14:18:55 UTC
(
hide
)
Description:
[PASSED QA] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-08-29 14:18:55 UTC
Size:
1.69 KB
patch
obsolete
>From 889063c0c9ef8b23d3717fb3fdefad9cd730f695 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Tue, 29 Jul 2014 16:09:18 -0300 >Subject: [PATCH] [PASSED QA] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN > >Proves GetMarcISSN returns empty ISSNs in the results array. > >To reproduce: > - Run $ prove -v t/db_dependent/Biblio.t > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/Biblio.t | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Biblio.t b/t/db_dependent/Biblio.t >index 901f761..f53b6a5 100755 >--- a/t/db_dependent/Biblio.t >+++ b/t/db_dependent/Biblio.t >@@ -143,6 +143,12 @@ sub run_tests { > $issns = GetMarcISSN( $marc_record, $marcflavour ); > is( scalar @$issns, 4, > 'GetMARCISSN handles records with multiple ISSN fields (count correct)'); >+ # Create an empty ISSN >+ $field = create_issn_field( "", $marcflavour ); >+ $marc_record->append_fields($field); >+ $issns = GetMarcISSN( $marc_record, $marcflavour ); >+ is( scalar @$issns, 4, >+ 'GetMARCISSN skips empty ISSN fields (Bug 12674)'); > > ## Testing GetMarcControlnumber > my $controlnumber; >@@ -254,19 +260,19 @@ sub create_issn_field { > } > > subtest 'MARC21' => sub { >- plan tests => 26; >+ plan tests => 27; > run_tests('MARC21'); > $dbh->rollback; > }; > > subtest 'UNIMARC' => sub { >- plan tests => 26; >+ plan tests => 27; > run_tests('UNIMARC'); > $dbh->rollback; > }; > > subtest 'NORMARC' => sub { >- plan tests => 26; >+ plan tests => 27; > run_tests('NORMARC'); > $dbh->rollback; > }; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12674
:
30304
|
30305
|
31284
|
31285
| 31287 |
31288