Bugzilla – Attachment 31288 Details for
Bug 12674
GetMarcISSN should not return empty ISSN
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12674: GetMarcISSN should not return empty ISSN
PASSED-QA-Bug-12674-GetMarcISSN-should-not-return-.patch (text/plain), 1.14 KB, created by
Kyle M Hall (khall)
on 2014-08-29 14:19:04 UTC
(
hide
)
Description:
[PASSED QA] Bug 12674: GetMarcISSN should not return empty ISSN
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-08-29 14:19:04 UTC
Size:
1.14 KB
patch
obsolete
>From c17b03d230fc215dc3c315a0def2b397e1fc2571 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Tue, 29 Jul 2014 16:12:52 -0300 >Subject: [PATCH] [PASSED QA] Bug 12674: GetMarcISSN should not return empty ISSN > >This patch makes GetMarcISSN test for empty subfield before pushing to the >result array. > >To test: >- Run the regression test >=> FAILS for all MARC flavours >- Apply the patch >- Run the regression test >=> SUCCESS: tests pass >- Sign off > >Sponsored-by: Universidad Nacional de Cordoba > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Biblio.pm | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index eb2ee2f..f2e7014 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -1730,7 +1730,8 @@ sub GetMarcISSN { > } > my @marcissns; > foreach my $field ( $record->field($scope) ) { >- push @marcissns, $field->subfield( 'a' ); >+ push @marcissns, $field->subfield( 'a' ) >+ if ( $field->subfield( 'a' ) ne "" ); > } > return \@marcissns; > } # end GetMarcISSN >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12674
:
30304
|
30305
|
31284
|
31285
|
31287
| 31288