Bugzilla – Attachment 31292 Details for
Bug 3186
Invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 3186 [QA Followup] - Don't return undef, just return
PASSED-QA-Bug-3186-QA-Followup---Dont-return-undef.patch (text/plain), 711 bytes, created by
Kyle M Hall (khall)
on 2014-08-29 14:39:43 UTC
(
hide
)
Description:
[PASSED QA] Bug 3186 [QA Followup] - Don't return undef, just return
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-08-29 14:39:43 UTC
Size:
711 bytes
patch
obsolete
>From 6d108752867d8cb951206c4514fa83ac7fcd3c25 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 29 Aug 2014 10:38:31 -0400 >Subject: [PATCH] [PASSED QA] Bug 3186 [QA Followup] - Don't return undef, just return > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/SMS.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/SMS.pm b/C4/SMS.pm >index 3a861a7..34cce27 100644 >--- a/C4/SMS.pm >+++ b/C4/SMS.pm >@@ -93,7 +93,7 @@ sub send_sms { > #Catch those errors and fail the sms-sending gracefully. > if ($@) { > warn $@; >- return undef; >+ return; > } > # warn 'failure' unless $sent; > return $sent; >-- >1.7.2.5
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=31292">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3186
:
31191
|
31192
|
31216
|
31290
|
31291
| 31292